Merge pull request #1097 from WordPress-Coding-Standards/feature/issu…

…e-933-namespaced-functions XSS.EscapeOutput sniff: Fix issue #933 - namespace separators.
WordPress · Aug 8, 2017 · 6d98f36 · 6d98f36
2 parents ab276d5 + c1d43bf
commit 6d98f36
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/WordPress/Sniffs/XSS/EscapeOutputSniff.php b/WordPress/Sniffs/XSS/EscapeOutputSniff.php
@@ -291,6 +291,11 @@ public function process_token( $stackPtr ) {
 				continue;
 			}
 
+			// Ignore namespace separators.
+			if ( T_NS_SEPARATOR === $this->tokens[ $i ]['code'] ) {
+				continue;
+			}
+
 			if ( T_OPEN_PARENTHESIS === $this->tokens[ $i ]['code'] ) {
 
 				if ( ! isset( $this->tokens[ $i ]['parenthesis_closer'] ) ) {

diff --git a/WordPress/Tests/XSS/EscapeOutputUnitTest.inc b/WordPress/Tests/XSS/EscapeOutputUnitTest.inc
@@ -225,3 +225,15 @@ echo 8 * 1.2; // Ok.
 <?= $var['foo']; ?><!-- Bad. -->
 <?= $var->foo ?><!-- Bad. -->
 <?php
+
+// Issue #933. OK.
+function do_footer_nav() {
+	echo \wp_kses_post(
+		\genesis_get_nav_menu(
+			[
+				'menu_class'     => 'menu genesis-nav-menu menu-footer',
+				'theme_location' => 'footer',
+			]
+		)
+	);
+}