Move Workshop meta from Inspector panel to Details block #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough WIP to get early feedback on the idea.
The faux meta boxes were removed, and the content there was put inside the Details block instead.
Inspector panels are inconvenient to work with, having this content in the block itself feels truer to Gutenberg's promise that WYSIWYG. That also lets us render things like the "Join..." button and CoC link programmatically, instead of hardcoding it in
post_content(see #195 for details on the problem that solves).The data like Duration is still saved to post meta like before.
Related #200