Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delay #137

Merged

Conversation

Aron-Kristofori
Copy link

@medzernik helped me with my first contribution and setting up all the tooling. from testing removing the delay seems completely fine and doesnt break anything.

@medzernik medzernik requested review from simon-wh and medzernik March 11, 2023 11:20
@medzernik medzernik added feature New feature or request good first issue Good for newcomers labels Mar 11, 2023
@medzernik medzernik added this to the 1.0.3 milestone Mar 11, 2023
@medzernik medzernik linked an issue Mar 11, 2023 that may be closed by this pull request
Copy link
Contributor

@medzernik medzernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved per discussion with @simon-wh

@medzernik medzernik modified the milestones: 1.0.3, 1.1 Dec 11, 2023
@medzernik medzernik changed the base branch from main to feature/rdev-wooting December 18, 2023 13:20
@medzernik medzernik self-requested a review December 18, 2023 14:19
@medzernik medzernik removed their assignment Dec 18, 2023
Copy link
Contributor

@medzernik medzernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, should be good

@medzernik medzernik merged commit a9339cd into WootingKb:feature/rdev-wooting Dec 18, 2023
medzernik added a commit that referenced this pull request Jan 10, 2024
* Removed unneccessary delay and tested

* Readded linux delays just in case.

* Fix manual merge

---------

Co-authored-by: medzernik <1900179+medzernik@users.noreply.github.com>
medzernik added a commit that referenced this pull request Jan 10, 2024
* Removed unneccessary delay and tested

* Readded linux delays just in case.

* Fix manual merge

---------

Co-authored-by: medzernik <1900179+medzernik@users.noreply.github.com>
medzernik pushed a commit that referenced this pull request Jan 10, 2024
^ This is the 1st commit message:

Feature/delay (#137)

* Removed unneccessary delay and tested

* Readded linux delays just in case.

* Fix manual merge

---------

Co-authored-by: medzernik <1900179+medzernik@users.noreply.github.com>
^ The commit message #2 will be skipped:

^ fmt
medzernik added a commit that referenced this pull request Jan 10, 2024
* Removed unneccessary delay and tested

* Readded linux delays just in case.

* Fix manual merge

---------

Co-authored-by: medzernik <1900179+medzernik@users.noreply.github.com>
medzernik added a commit that referenced this pull request Jan 10, 2024
* Removed unneccessary delay and tested

* Readded linux delays just in case.

* Fix manual merge

---------

Co-authored-by: medzernik <1900179+medzernik@users.noreply.github.com>
medzernik added a commit that referenced this pull request Jan 10, 2024
* Removed unneccessary delay and tested

* Readded linux delays just in case.

* Fix manual merge

---------

Co-authored-by: medzernik <1900179+medzernik@users.noreply.github.com>
@WootingKb WootingKb locked and limited conversation to collaborators Jan 10, 2024
@medzernik medzernik removed this from the 1.1 milestone Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App delay lowering
2 participants