Delete existing system resource during enrollment #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the enrollment, it is possible that the system resource name applied during enrollment deffers from the existing one. To prevent this problem, this commit checks the existing system resources and delete them before applying new system resource. Test plan: Passed - successfully finish the subcloud enrollment with this change. The system resource applied during the enrollment deffers from the existing system resource. Verify the system resource can be insync and reconciled after enrollment. Signed-off-by: Yuxing Jiang <Yuxing.Jiang@windriver.com>
wasnio
approved these changes
Nov 27, 2024
enzocandotti
approved these changes
Nov 27, 2024
wasnio
pushed a commit
to wasnio/cloud-platform-deployment-manager
that referenced
this pull request
Nov 27, 2024
During the enrollment, it is possible that the system resource name applied during enrollment deffers from the existing one. To prevent this problem, this commit checks the existing system resources and delete them before applying new system resource. Test plan: Passed - successfully finish the subcloud enrollment with this change. The system resource applied during the enrollment deffers from the existing system resource. Verify the system resource can be insync and reconciled after enrollment. Signed-off-by: Yuxing Jiang <Yuxing.Jiang@windriver.com> (cherry picked from commit d62d60d)
yjian118
added a commit
that referenced
this pull request
Nov 27, 2024
During the enrollment, it is possible that the system resource name applied during enrollment deffers from the existing one. To prevent this problem, this commit checks the existing system resources and delete them before applying new system resource. Test plan: Passed - successfully finish the subcloud enrollment with this change. The system resource applied during the enrollment deffers from the existing system resource. Verify the system resource can be insync and reconciled after enrollment. Signed-off-by: Yuxing Jiang <Yuxing.Jiang@windriver.com> (cherry picked from commit d62d60d) Co-authored-by: Yuxing Jiang <yuxing.jiang@windriver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the enrollment, it is possible that the system resource name applied during enrollment deffers from the existing one. To prevent this problem, this commit checks the existing system resources and delete them before applying new system resource.
Test plan:
Passed - successfully finish the subcloud enrollment with this change. The system resource applied during the enrollment deffers from the existing system resource. Verify the system resource can be insync and reconciled after enrollment.