Name Powershell Script and Log Files Uniquely #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # | ||
| # @return [Hash] :stdout and :stderr | ||
| # | ||
| # @return [Hash] :stdout and :stderr |
There was a problem hiding this comment.
Looks like this was an accident, which reminds I should probably enable RuboCop on this project and add an automated build.
There was a problem hiding this comment.
Yup. Fixing.
@sneal - pushed with the fix.
c1f1ada to
11220fa
Compare
In order to allow winrm-elevated to run concurrently against the same Windows server, name the powershell script uploaded to the server using a randomly generated UUID. In addition, the logfiles generated by the script will be named using the GetTempFileName to ensure uniqueness. We will clean up the logfiles when the script is finished. Since the same script can be uploaded once and invoked multiple times it will be left intact.
11220fa to
fad4e00
Compare
|
LGTM. I think we can cross the debugging bridge when we need. Perhaps we look for an environment variable, when set we skip the log deletion. |
|
👍 yeaah I wouldn't worry about the debug scenario |
|
tests work on my machine. |
|
Thanks guys. Will this be 0.3.0? |
|
yup. released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow winrm-elevated to run concurrently against the
same Windows server, name the powershell script uploaded to the server
using a randomly generated UUID.
In addition, the logfiles generated by the script will be named using the
pid of the script's running process.
We will clean up the logfiles when the script is finished. Since the same
script can be uploaded once and invoked multiple times it will be left intact.
The intent here is to deal with the issue described here: #5
@mwrock @sneal if you could review and possibly merge when possible that would be great.
Open for discussion of course. Thanks!