Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Radio button misalignment #7

Closed
Markus-ipse opened this issue Sep 21, 2017 · 2 comments
Closed

Radio button misalignment #7

Markus-ipse opened this issue Sep 21, 2017 · 2 comments
Assignees
Labels

Comments

@Markus-ipse
Copy link
Contributor

The little highlight that indicates that a radio button is selected is not completely centered.
I think it might be due to some odd pixel rounding when it comes to its top and left position.

image

My screen resolution and scaling, if it helps:
image

@Wikiki Wikiki self-assigned this Sep 21, 2017
@Wikiki Wikiki added the bug label Sep 21, 2017
Wikiki added a commit that referenced this issue Sep 21, 2017
@Wikiki
Copy link
Owner

Wikiki commented Sep 21, 2017

Hi @Markus-ipse ,

It should be fixed.

Regards,

@Wikiki Wikiki closed this as completed Sep 21, 2017
@Markus-ipse
Copy link
Contributor Author

Markus-ipse commented Sep 21, 2017

It turns out there's still some slight alignment issues on small and medium
image

I think it's due to rounding errors, so I tried a different solution. Instead of setting the size of the ::after element with the mixin, I just use a transform: scale(0.5) on it instead. It seem to have solved the issue and it allowed me override less attributes for each size.

I created a PR (#8) with my changes if you are interested 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants