Skip empty revisions when using --xmlrevisions #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the download would die, and need to be resumed from the start.
|
This issue also affects the much smaller german version, where Hilfe:Mitmachhilfe has a deleted revision too. This PR fixes it. The german one can be saved in under 15 minutes, so it'd be a good one to test with. |
|
Hmm right, how did I forget to consider revision deletion? Maybe we should try to keep whatever information is left public (like the edit summary if available) but maybe not. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the download would die, and need to be resumed from the start.
I ran into it while working on this, which ended up dying on FamilySearch Wiki:WikiProject England Parish Tables Part 2, which happens to have a deleted revision (apparently the only deleted revision on a non-deleted page). I was able to successfully redownload with this patch. (Well, I actually made another change so that it wouldn't restart from the beginning, but instead the project namespace - if I had had to redo everything, it would have lost half a week's data, but instead I only lost about half a day's data.)