Use session.get instead of requests.get in getXMLHeader
#438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`session.get` uses our configured User-Agent, while `requests.get` uses the default one.
|
This relies on generateXMLDump() and getXMLHeader() actually passing the |
|
I'm not entirely sure about how the defaults are handled here. |
yzqzss
added a commit
to saveweb/wikiteam3
that referenced
this pull request
Jan 4, 2023
follow upstream: WikiTeam#438 tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session.getuses our configured User-Agent, whilerequests.getuses the default one. Needed forpython2 -u dumpgenerator.py --xml --xmlrevisions --images https://fidopedia.fido.de/, as that site rejects the requests user agent.(That site also requires other stuff; see this branch (perma), though that's not fully complete.)