Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace pbkdf2 with Web Crypto API for derivePairingCodeKey #1276

Merged

Conversation

jlucaso1
Copy link
Contributor

@jlucaso1 jlucaso1 commented Mar 1, 2025

No description provided.

@jlucaso1 jlucaso1 changed the title refactor: replace pbkdf2 with Web Crypto API for derivePairingCodeKey… refactor: replace pbkdf2 with Web Crypto API for derivePairingCodeKey Mar 1, 2025
@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@jlucaso1/Baileys#refactor-pbkdf2-webcrypto
# YARN v2
yarn add @whiskeysockets/baileys@jlucaso1/Baileys#refactor-pbkdf2-webcrypto

@purpshell
Copy link
Collaborator

Steam engine, or AI overlord? Those are some fast PRs

Copy link
Collaborator

@purpshell purpshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be supported on node 15+ (note to self please update the engine requirements on the package.json)

Later on, it should be moved to the SubtleCrypto class directly to reduce dependance on node:crypto

Also as an additional note, please bundle up changes of the same nature into a singular PR. You can add more similar commits to this branch and we'll merge them in one go instead.

@purpshell purpshell added this to the 6.7.14 milestone Mar 1, 2025
@purpshell purpshell merged commit fdce228 into WhiskeySockets:master Mar 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants