-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dev package dependencies #1270
Upgrade dev package dependencies #1270
Conversation
Thanks for your contribution. The next step is to wait for review and approval to merge it to main repository The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it. To test this PR you can run the following command below:
|
Efficiency at it's peak |
TYVM! A lot of what you have brought here has been on my to-do list for the past while. As for testing, you can start work on it but I don't think it matches with my view on testing. The goal is to implement both end-to-end (and provided with test numbers as well) and mock testing to see if a PR or a branch change works successfully before releasing a version. As for tree-shaking, that would be appreciated as well. Any contributions to this project are welcome. As for audio-decode, I am not sure where to put it for now. I'm looking into more and more options and might either eliminate most of the peer deps or find another way to include them. |
@purpshell Yeah I agree with e2e tests, maybe we need to implement a pseudo WhatsApp compatible server for these tests to not use real numbers and fast run (a bit of difficulty and hard work, but I think this is the way). |
For now, I give the OK on keeping it as an optional peer-dep. Will merge |
@purpshell Apparently this commit got lost in limbo. I can't find any reference to it in the main branch. |
Changes:
libphonenumber-js
as it is no longer used in the project. (It was previously used in an example, but has since been removed.)node_modules
and improves Language Server Protocol (LSP) performance in the IDE.) Thesrc/Utils/noise-handler.ts
file was updated due to stricterBuffer
type checking in TypeScript 5.audio-decode
to peer dependencies and marked it as optional.These changes reduced the
node_modules
size in the development environment from 341.5 MiB to 300.1 MiB.My next steps (in a separate pull request) will be to remove the Jest dependency and utilize the new Node.js native test runner. (I will migrate all existing tests.) I estimate this will further reduce the
node_modules
size by approximately 104.3 MiB.In the future, I plan to optimize the library's bundling to decrease the size of the compiled code through tree shaking. Upgrading to TypeScript 5+ will facilitate this process.