Skip to content

Commit

Permalink
Small bug fixes
Browse files Browse the repository at this point in the history
- Closed #71
- Fixed preview window not change to user specified dark/light mode on opening.
- Simplified code slightly.
- Preference values are now clamped between their maximum and minimum allowed values.
- Created v1.9.3 release build.
  • Loading branch information
WhenLifeHandsYouLemons committed Apr 18, 2024
1 parent 3cf6aba commit 6c5421a
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 11 deletions.
22 changes: 12 additions & 10 deletions Encryptext.pyw
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,12 @@ except FileNotFoundError:
version = "'Encryptext Travel Mode'"

font_scale_factor = settings["otherSettings"]["fontScaleFactor"]
theme = settings["otherSettings"]["theme"]

"""
Custom Classes
"""
if settings["otherSettings"]["theme"] == "light":
if theme == "light":
bg = "white"
text = "black"
code_bg = "#f8f8f8"
Expand Down Expand Up @@ -199,7 +200,7 @@ class TextLineNumbers(tk.Canvas):
def __init__(self, *args, **kwargs):
tk.Canvas.__init__(self, *args, **kwargs)
self.textwidget = None
if settings["otherSettings"]["theme"] == "light":
if theme == "light":
self.configure(bg="#f7f7f7")
else:
self.configure(bg="#1c1c1c")
Expand All @@ -216,7 +217,7 @@ class TextLineNumbers(tk.Canvas):
if dline is None: break
y = dline[1]
linenum = str(i).split(".")[0]
if settings["otherSettings"]["theme"] == "light":
if theme == "light":
self.create_text(2,y,anchor="nw", text=linenum, fill="#000000")
else:
self.create_text(2,y,anchor="nw", text=linenum, fill="#ffffff")
Expand Down Expand Up @@ -310,7 +311,7 @@ class PreferenceWindow(tk.Toplevel):
ttk.Separator(self.pref_window, orient="horizontal").pack(side="top", fill="x", padx=100, pady=10)

# Theme selector
self.selected_theme = tk.StringVar(value=settings["otherSettings"]["theme"])
self.selected_theme = tk.StringVar(value=theme)
self.theme_label = WrappedLabel(self.pref_window, text="Theme: ", font=(settings["otherSettings"]["fontStyle"], int(round(11*font_scale_factor))))
self.light_theme_val = ttk.Radiobutton(self.theme_label, text="Light", value="light", variable=self.selected_theme)
self.dark_theme_val = ttk.Radiobutton(self.theme_label, text="Dark", value="dark", variable=self.selected_theme)
Expand Down Expand Up @@ -386,12 +387,12 @@ class PreferenceWindow(tk.Toplevel):
global settings

# Save preferences that have been selected
settings["maxRecentFiles"] = self.selected_recent_files.get()
settings["maxRecentFiles"] = max(0, min(20, self.selected_recent_files.get()))
settings["otherSettings"]["fontStyle"] = self.selected_font_style.get()
settings["otherSettings"]["fontScaleFactor"] = self.selected_font_sf.get()
settings["otherSettings"]["fontScaleFactor"] = max(0.5, min(2, self.selected_font_sf.get()))
settings["otherSettings"]["theme"] = self.selected_theme.get()
settings["otherSettings"]["autoSave"] = self.selected_auto_save.get()
settings["otherSettings"]["autoSaveInterval"] = self.selected_auto_save_interval_val.get()
settings["otherSettings"]["autoSaveInterval"] = max(1, min(600, self.selected_auto_save_interval_val.get()))
settings["otherSettings"]["language"] = self.language_val.get()
settings["otherSettings"]["showLineNumbers"] = self.selected_show_line_no.get()
settings["otherSettings"]["wrapLines"] = self.selected_wrap_line.get()
Expand Down Expand Up @@ -438,7 +439,8 @@ class PreviewWindow(tk.Toplevel):
if current_tab == -1:
return None

self.frame.load_html(markdown(textboxes[current_tab].get("1.0", tk.END)))
text = textboxes[current_tab].get("1.0", tk.END)
self.updateFrame(text)
self.frame.pack(fill="both", expand=True)

def updateFrame(self, text: str) -> None:
Expand All @@ -452,7 +454,7 @@ class PreviewWindow(tk.Toplevel):
Window Settings
"""
# Create the window and configure the background for theme changes
if settings["otherSettings"]["theme"] == "light":
if theme == "light":
styles = ttk.Style(theme="cosmo")
else:
styles = ttk.Style(theme="darkly")
Expand Down Expand Up @@ -1378,7 +1380,7 @@ def addNewTab(Event=None):

if settings["otherSettings"]["highlightActiveLine"] == True:
# Adapted from https://stackoverflow.com/a/9720858
if settings["otherSettings"]["theme"] == "light":
if theme == "light":
textboxes[-1].tag_configure("current_line", background="#e9e9e9")
else:
textboxes[-1].tag_configure("current_line", background="#262626")
Expand Down
2 changes: 1 addition & 1 deletion builds/build_number.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
30
33
Binary file modified builds/release/encryptext_installer_v1.9.3_64bit.exe
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 comments on commit 6c5421a

Please sign in to comment.