Introduce semi-expanded format for all containers #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awalterschulze
approved these changes
Jun 23, 2021
| LastFitsFun = last_fits_fun(LastFits, Values), | ||
| BreakKind = break_behaviour(Meta, Values, BreakKind0), | ||
| BreakFun = break_fun(BreakKind), | ||
| BreakBehaviour = break_behaviour(Meta, Values, BreakKind), |
| @@ -535,16 +527,14 @@ has_opening_line_break(Meta, [HeadValue | _]) -> | |||
|
|
|||
| has_any_break_between([Head | [Head2 | _] = Tail]) -> | |||
| has_break_between(Head, Head2) orelse has_any_break_between(Tail); | |||
| has_any_break_between([{cons, _, Head, Tail}]) -> | |||
There was a problem hiding this comment.
Ah I see this is for the new case you brought up
| group(concat(nest(concat(Left, Doc), ?INDENT, break), Right)). | ||
| group(concat(nest(concat(Left, Doc), ?INDENT, break), Right)); | ||
| surround_container(#break{inner = ForceInner, outer = ForceOuter}, Left, Doc, Right) -> | ||
| InnerDoc = group(concat(maybe_force_breaks(ForceInner), Doc)), |
There was a problem hiding this comment.
So Doc is now always grouped, does this still cover the line case, which was not grouped?
There was a problem hiding this comment.
Yes, using force_breaks() turns break() into line() so that still works correctly and removes one case
| ), | ||
| ?assertSame( | ||
| "-export([\n" | ||
| " bar/1, baz/1\n" |
There was a problem hiding this comment.
Oh interesting.
I guess this is now a thing.
Almost feel like export should be special cased, but it is probably fine.
There was a problem hiding this comment.
Yes, I thought about this as well, but it seems consistent, if everything fits on a single line
| "-export([\n" | ||
| " foo/1,\n" | ||
| " bar/1,\n" | ||
| " baz/1, baz/2\n" |
15526cd to
6b2ac75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the semi-expanded format introduced for function calls in #305 to all the containers.