-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scroll-animations] make animation-timeline
, animation-range-start
and animation-range-end
reset-only longhands of the animation
shorthand
#40351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 8656c6a) |
nt1m
approved these changes
Feb 10, 2025
8656c6a
to
260cd38
Compare
EWS run on current version of this PR (hash 260cd38) |
…` and `animation-range-end` reset-only longhands of the `animation` shorthand https://bugs.webkit.org/show_bug.cgi?id=287398 Reviewed by Tim Nguyen. The CSS WG resolved in w3c/csswg-drafts#6946 (comment) to make the new CSS properties introduced to support Scroll-driven Animations – `animation-timeline`, `animation-range-start` and `animation-range-end` – reset-only longhands of the `animation` shorthand. To that end, we add those properties to the `"longhands"` property for `animation` in `CSSProperties.json` and deal with them when relevant: - in `CSSPropertyParser.cpp` we set `nullptr` values for those properties to reset any value previously set and ensure those properties have the right initial values for serialization purposes. - in `ComputedStyleExtractor.cpp` we return an empty value whenever we attempt to serialize the `animation` shorthand in the computed style when one of those reset-only longhands was otherwise set. - in `ShorthandSerializer.cpp` we do similar work when serializing the specified value. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-shorthand-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-shorthand-expected.txt: * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::animationShorthandValue): * Source/WebCore/css/ShorthandSerializer.cpp: (WebCore::ShorthandSerializer::serializeLayered const): * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::initialValueForLonghand): (WebCore::consumeAnimationValueForShorthand): (WebCore::CSSPropertyParser::consumeAnimationShorthand): Canonical link: https://commits.webkit.org/290168@main
260cd38
to
91fb05a
Compare
Committed 290168@main (91fb05a): https://commits.webkit.org/290168@main Reviewed commits have been landed. Closing PR #40351 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
91fb05a
260cd38
🧪 mac-wk2-stress🧪 mac-intel-wk2