Webpack

[DannyMcwaves]

eslint done.

[JoshuaVSherman]

@DannyMcwaves please fix merge conflict

[JoshuaVSherman]

@DannyMcwaves please fix the 3 failing unit tests, this was my fault, sorry

[DannyMcwaves]

@JoshuaVSherman I was planning to have a look at the tests today. I'd take care of it.

[JoshuaVSherman]

@DannyMcwaves the tests are still failing

[DannyMcwaves]

@JoshuaVSherman circleCI is missing some modules. My current tests run just fine.

[JoshuaVSherman]

Ok I'll have to work on that next week

…

On Thu, May 24, 2018, 5:21 AM Danny Mcwaves ***@***.***> wrote: @JoshuaVSherman <https://github.com/JoshuaVSherman> circleCI is missing some modules. My current tests run just fine. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1140 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMuN2BL0lNA-vpLbDwJ9Z5G3RIfJfU77ks5t1nuLgaJpZM4UJldf> .

[JoshuaVSherman]

@DannyMcwaves pulled down your branch and yarn installed, got these warnings:
warning " > extract-text-webpack-plugin@3.0.2" has incorrect peer dependency "webpack@^3.1.0".
warning " > aurelia-tools@2.0.0" has incorrect peer dependency "babel-eslint@^7.2.3".
warning "karma-webpack > webpack-dev-middleware@1.12.2" has incorrect peer dependency "webpack@^1.0.0 || ^2.0.0 || ^3.0.0".

[JoshuaVSherman]

@DannyMcwaves Ran npm test on my local dev and got the same errors from CircleCI:

FAIL test/jest-unit/Login_.spec.js
● Test suite failed to run

Cannot find module 'hawk'
  
  at Object.<anonymous> (node_modules/request/request.js:9:12)

FAIL test/jest-unit/Register_.spec.js
● Test suite failed to run

Cannot find module 'hawk'
  
  at Object.<anonymous> (node_modules/request/request.js:9:12)

FAIL test/jest-unit/User_.spec.js
● Test suite failed to run

Cannot find module 'hawk'

[JoshuaVSherman]

@DannyMcwaves from npm run cleaninstall, I got these warnings:
warning material-ui@1.0.0-beta.47: You can now upgrade to @material-ui/core
warning snyk > proxy-agent > socks-proxy-agent > socks@1.1.10: If using 2.x branch, please upgrade to at least 2.1.6 to avoid a serious bug with socket data flow and an import issue introduced in 2.1.0
warning enzyme > rst-selector-parser > nearley > nomnom@1.6.2: Package no longer supported. Contact support@npmjs.com for more info.
warning istanbul-combine > istanbul > fileset > minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
warning webpack-cli > jscodeshift > nomnom@1.8.1: Package no longer supported. Contact support@npmjs.com for more info.
warning webpack-cli > webpack-addons > jscodeshift > nomnom@1.8.1: Package no longer supported. Contact support@npmjs.com for more info.
warning webpack-cli > jscodeshift > babel-preset-es2015@6.24.1: 🙌 Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!
warning webpack-cli > webpack-addons > jscodeshift > babel-preset-es2015@6.24.1: 🙌 Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!

[JoshuaVSherman]

@DannyMcwaves npm test now works fine, it seems the node modules needed a refresh

[JoshuaVSherman]

@DannyMcwaves this discussion has the answer in it, just fyi wmonk/create-react-app-typescript#154

[DannyMcwaves]

@JoshuaVSherman Regarding #1127 (comment), we cannot upgrade material-ui beta.

the timer picker component depends on this version. Installing a @material-ui/core breaks the app.

Also, with webpack-cli, it's an issue with jscodeshift. it has to update it's dependencies.

[JoshuaVSherman]

Ok we will just follow the repo for updates, thanks

…

On Sun, May 27, 2018, 3:33 AM Danny Mcwaves ***@***.***> wrote: @JoshuaVSherman <https://github.com/JoshuaVSherman> Regarding #1127 (comment) <#1127 (comment)>, we cannot upgrade material-ui beta. [image: screen shot 2018-05-27 at 7 18 27 am] <https://user-images.githubusercontent.com/16429468/40583445-91f97062-617e-11e8-8562-c064697056a3.png> the timer picker component depends on this version. Installing a @material-ui/core breaks the app. [image: screen shot 2018-05-27 at 7 31 50 am] <https://user-images.githubusercontent.com/16429468/40583525-1e6d3d5c-6180-11e8-9fa4-c0bc25aa10a4.png> Also, with webpack-cli, it's an issue with jscodeshift. it has to update it's dependencies. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1140 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMuN2KU5zSZoz6t6ng-_RwGOjpLjTXyLks5t2lawgaJpZM4UJldf> .