Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix / unsafe svg #43

Merged
merged 4 commits into from
Nov 6, 2024
Merged

fix / unsafe svg #43

merged 4 commits into from
Nov 6, 2024

Conversation

itsamoreh
Copy link
Contributor

Closes

#42

Link to test

coming soon...

Description

Removes enable-svg.php - there was no sanitization of svgs.

If we need SVG support we can use a safe SVG plugin instead.

Related Tickets & Documents

N/A

Mobile & Desktop Screenshots/Recordings

N/A

Added to documentation?

  • 🙅 No documentation needed (Removing a feature that was not documented)

Added tests?

  • 🙅 No, because they aren't needed

Testing Instructions

  1. Pull this branch
  2. Verify that SVG support has been removed from the theme

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

(this should probably be moved into a plugin)
This will be added via the wds-bt helper plugin instead or via any svg plugin on the plugin repo.
@itsamoreh itsamoreh requested a review from khleomix as a code owner October 18, 2024 21:21
@itsamoreh itsamoreh marked this pull request as draft October 18, 2024 21:22
@itsamoreh itsamoreh marked this pull request as ready for review October 29, 2024 17:34
Copy link
Contributor

@thatmitchcanter thatmitchcanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough - thanks!

@thatmitchcanter thatmitchcanter removed the request for review from lswilson November 6, 2024 20:06
@thatmitchcanter thatmitchcanter merged commit a2bde77 into main Nov 6, 2024
3 of 4 checks passed
@thatmitchcanter thatmitchcanter deleted the fix/sanitize-svg branch November 6, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants