Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/housekeeping #109

Merged
merged 13 commits into from
Jun 28, 2021
Merged

Feature/housekeeping #109

merged 13 commits into from
Jun 28, 2021

Conversation

gregrickaby
Copy link
Contributor

@gregrickaby gregrickaby commented Jun 28, 2021 •
edited
Loading

Closes #104
Closes #105
Closes #106

Description

  • Updates dependencies and devDependencies
  • Updates to latest WordPress Coding Standards (and WDS implementation of them)
  • Adds support for Github's Dependabot and Assertions
  • Bulk coding standards formatting
  • I followed WordPress Create Block as a guide for updating this plugin

Screenshot

screenshot

Steps to verify the solution

  1. gh pr checkout 109
  2. npm ci --legacy-peer-deps
  3. composer install
  4. npm run build
  5. npm run lint

@gregrickaby gregrickaby requested a review from khleomix June 28, 2021 18:57
khleomix
khleomix approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@khleomix khleomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working my end. Should be good to go.

@gregrickaby gregrickaby merged commit 7ddccc9 into main Jun 28, 2021
@gregrickaby gregrickaby deleted the feature/housekeeping branch June 28, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khleomix khleomix khleomix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project doesn't build npm install --production fails Built files for distribution
2 participants
@gregrickaby @khleomix