-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap core blocks with wp-block-* classes #943
Conversation
Some core blocks have these classes, some don't. This will wrap the core blocks we support that don't have these classes with wp-block-* classes.
@itsamoreh |
Nice catch! Thanks Jenna. Feels a bit gross but I'll add a case for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see the other sass partials for adding containers to the other newly created classes. ie: .wp-block-heading
, .wp-block-list
, .wp-block-html
Thanks!
…eature/wrap-core-blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
DESCRIPTION
Some core blocks have these classes, some don't. This will wrap the core blocks we support that don't have these classes with wp-block-* classes.
SCREENSHOTS
STEPS TO VERIFY
Verify that the core blocks in the array have the block wrapper spans and the expected class names.