Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap core blocks with wp-block-* classes #943

Merged
merged 15 commits into from
Oct 14, 2022
Merged

Conversation

itsamoreh
Copy link
Contributor

DESCRIPTION

Some core blocks have these classes, some don't. This will wrap the core blocks we support that don't have these classes with wp-block-* classes.

SCREENSHOTS

screen-capture 2022-10-07 at 10 18 33 AM

STEPS TO VERIFY

Verify that the core blocks in the array have the block wrapper spans and the expected class names.

Some core blocks have these classes, some don't. This will wrap the core blocks we support that don't have these classes with wp-block-* classes.
@jennahines
Copy link
Contributor

@itsamoreh core/freeform returns null for $block['blockName'] so it's not being wrapped.
Screen Shot 2022-10-13 at 9 50 47 AM

@itsamoreh
Copy link
Contributor Author

@itsamoreh core/freeform returns null for $block['blockName'] so it's not being wrapped.

Nice catch! Thanks Jenna.

Feels a bit gross but I'll add a case for null and wrap it with a span.wp-block-freeform unless someone has a better idea?

Copy link
Contributor

@webdevstudios-hosting webdevstudios-hosting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the other sass partials for adding containers to the other newly created classes. ie: .wp-block-heading, .wp-block-list, .wp-block-html

Thanks!

Copy link
Contributor

@oliverharrison oliverharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

@oliverharrison oliverharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@oliverharrison oliverharrison merged commit 031d9eb into main Oct 14, 2022
@oliverharrison oliverharrison deleted the feature/wrap-core-blocks branch October 14, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants