Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds fonts back to copyplugin #789

Merged
merged 2 commits into from
May 9, 2022
Merged

Adds fonts back to copyplugin #789

merged 2 commits into from
May 9, 2022

Conversation

coreymcollins
Copy link
Contributor

@coreymcollins coreymcollins commented Nov 12, 2021 •
edited
Loading

DESCRIPTION

In working through #785, I realized fonts weren't being copied to build anymore in the CopyPlugin plugin. This adds 'em back!

SCREENSHOTS

image

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

STEPS TO VERIFY

  1. Add fonts to src/fonts
  2. Run npm run build
  3. See fonts in the build/fonts directory

DOCUMENTATION

Will this pull request require updating the wd_s wiki?

Don't think so, because this should have been working already (and was before!).

@coreymcollins coreymcollins removed their assignment Nov 24, 2021
@coreymcollins coreymcollins removed the request for review from gregrickaby April 27, 2022 15:44
nickyiie
nickyiie approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@nickyiie nickyiie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coreymcollins coreymcollins merged commit a3ea2cf into main May 9, 2022
@coreymcollins coreymcollins deleted the hotfix/font-copy-plugin branch May 9, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickyiie nickyiie nickyiie approved these changes

Assignees
No one assigned
Labels
bug r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coreymcollins @nickyiie @gregrickaby