Critical CSS #744
Critical CSS #744
Conversation
|
This PR is more of a proof of concept at the moment, I think, because there's probably a lot more to figure out as far as Critical CSS goes. This does the job for our own partials, but how do we handle Critical CSS in regards to styles set in the Tailwind config file? We'll also need to write up documentation on when and how to add to Critical CSS. Since we don't include a hero or anything like that in the theme anymore, for instance, we'll want to educate the team on what to add to Critical CSS so we're not bloating it but also not missing anything important. |
|
@coreymcollins Nicely done. I think you should demo during the FEEBEE Scrum tomorrow!!! |
|
Merged |
Merging main into feature branch
|
Giving this a bump after a fresh merge from |
DESCRIPTION
This separates some critical CSS partials and compiles them into their own file, which is then added inline in the
<head>.What I did:
menus.scss,mobile-menus.scss, andheader.scssfrom their original locations to asrc/scss/critical/directory.webpack.config.jsfile to produce multiple build files forindex.cssandcritical.css<head>What I'd like to get some 👀 on:
critical.cssas neededSCREENSHOTS
OTHER
STEPS TO VERIFY
npm run build<head>and the header & menus are looking goodDOCUMENTATION
Will this pull request require updating the wd_s wiki?
I can see us wanting to update around Critical CSS paths and what should be included there, so I'll start looking at the existing docs to see where this could best fit.