Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/preload assets #741

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Feature/preload assets #741

merged 2 commits into from
Sep 17, 2021

Conversation

coreymcollins
Copy link
Contributor

@coreymcollins coreymcollins commented Sep 16, 2021 •
edited
Loading

DESCRIPTION

Preloads the custom logo and adds a hook to preload other assets, like fonts.

SCREENSHOTS

image

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

STEPS TO VERIFY

  1. Checkout the branch
  2. Upload a site logo using the Customizer
  3. Verify the logo is preloaded in the head

@gregrickaby gregrickaby merged commit 197c88d into main Sep 17, 2021
@gregrickaby gregrickaby deleted the feature/preload-assets branch September 17, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregrickaby gregrickaby gregrickaby approved these changes

Assignees

@gregrickaby gregrickaby

@coreymcollins coreymcollins

Labels
enhancement r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coreymcollins @gregrickaby