Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default deps for asset file when built file can't load #691

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Update default deps for asset file when built file can't load #691

merged 1 commit into from
Jun 16, 2021

Conversation

bradp
Copy link
Contributor

@bradp bradp commented Jun 16, 2021

DESCRIPTION

Fallback was added in abb4de7. This updates it to match the dependencies to what gets populated in that asset file.

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

@bradp bradp requested a review from coreymcollins as a code owner June 16, 2021 00:54
@gregrickaby gregrickaby merged commit 133bf19 into main Jun 16, 2021
@gregrickaby gregrickaby deleted the feature/fix-fallback-asset-loading-depenedencies branch June 16, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregrickaby gregrickaby gregrickaby approved these changes

@coreymcollins coreymcollins Awaiting requested review from coreymcollins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradp @gregrickaby