Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves package dependencies #564

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Conversation

coreymcollins
Copy link
Contributor

@coreymcollins coreymcollins commented Dec 9, 2020

Closes #563

DESCRIPTION

Moves some required dependencies to dependencies and keeps the rest in devDependencies in the package file.

SCREENSHOTS

screenshot of dependencies and devDependencies

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

STEPS TO VERIFY

  1. Check out the branch
  2. Run npm install --production && npm run build
  3. Load the site and verify everything is built as expected

DOCUMENTATION

I don't believe we'll need to update any documentation here.

Copy link
Contributor

@jrfoell jrfoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coreymcollins coreymcollins merged commit 0efd22c into main Dec 14, 2020
@coreymcollins coreymcollins deleted the feature/#563-package-dependencies branch December 14, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move JS dependencies required to build out of devDependencies
3 participants