Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added composer/installers #561

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Added composer/installers #561

merged 1 commit into from
Nov 10, 2020

Conversation

jrfoell
Copy link
Contributor

@jrfoell jrfoell commented Nov 9, 2020 •
edited
Loading

Closes #560

DESCRIPTION

Added composer/installers as a requirement

SCREENSHOTS

composer-installers

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

STEPS TO VERIFY

How do we test this?
Run composer install in the wd_s directory and verify that composer/installers is installed. Once this change is committed, wd_s should be installed in the correct directory.

DOCUMENTATION

Will this pull request require updating the wd_s wiki? - Nope

gregrickaby
gregrickaby approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@gregrickaby gregrickaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrfoell Thank you!

@gregrickaby gregrickaby merged commit bdabd01 into main Nov 10, 2020
@gregrickaby gregrickaby deleted the feature/560-composer-installers branch November 10, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregrickaby gregrickaby gregrickaby approved these changes

@coreymcollins coreymcollins Awaiting requested review from coreymcollins

@aubreypwd aubreypwd Awaiting requested review from aubreypwd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

composer.json lacks composer/installers requirement
2 participants
@jrfoell @gregrickaby