Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage @wordpress/scripts as primary tool chain #552

Merged
merged 6 commits into from
Sep 23, 2020
Merged

Leverage @wordpress/scripts as primary tool chain #552

merged 6 commits into from
Sep 23, 2020

Conversation

asharirfan
Copy link
Contributor

@asharirfan asharirfan commented Sep 22, 2020 •
edited by coreymcollins
Loading

Closes #546

DESCRIPTION

This PR removes the use of imagemin and svgo cli. And adds support for optimizing images via @wordpress/scripts for the theme.

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

@asharirfan asharirfan mentioned this pull request Sep 22, 2020
Closed
4 tasks
@asharirfan asharirfan changed the base branch from master to feature/tailwind September 23, 2020 14:12
@asharirfan asharirfan marked this pull request as ready for review September 23, 2020 14:13
@asharirfan asharirfan self-assigned this Sep 23, 2020
@coreymcollins coreymcollins merged commit 85ec478 into feature/tailwind Sep 23, 2020
@coreymcollins coreymcollins deleted the feature/images-optimization branch September 23, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreymcollins coreymcollins coreymcollins approved these changes

Assignees

@asharirfan asharirfan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leverage @wordpress/scripts as our primary tool chain
2 participants
@asharirfan @coreymcollins