Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/#503 default button colors #504

Merged
merged 4 commits into from
Nov 4, 2019

Conversation

ImBigWill
Copy link
Contributor

Closes #503

DESCRIPTION

  • Our default button styles weren't allowing for user selected styles to display on the Front End. This PR will remedy that issue. I also ensured the selected button color remains on hover and the entire button will just get the opacity change.

SCREENSHOTS

BackEnd
FrontEnd

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

STEPS TO VERIFY

Create a new page or post and add a default button. Save the post to ensure there are styles in place if nothing is selected. Then edit the page, change the button styles around to your liking, save the update and confirm the backend matches the front end.

@coreymcollins coreymcollins merged commit ccd9f4d into master Nov 4, 2019
@coreymcollins coreymcollins deleted the hotfix/#503-default-button-colors branch November 4, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Gutenberg Buttons Colors
3 participants