Feature/#438 update grid #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer width elemenets
|
@coreymcollins updated a couple things here:
|
gregrickaby
suggested changes
Jan 24, 2019
There was a problem hiding this comment.
Hey @jomurgel and @coreymcollins! Great work here. I really appreciate dropping the sidebar, and all other the little details. Here are a couple of suggestions:
- Move Font Color and Animation from "Other Options" --> "Display Options".
- When I set a block to Full [width] in Display Options, the background doesn't actually extend full width. It could be, that I misunderstand what full width should be?
|
Thanks, Greg! Interesting catch on no. 2 above. That definitely was extending full-width previously (per the screenshots earlier in the PR), so there must be a commit here that walked that back at some point. I think the adjustment in no. 1 makes sense as well. 👍 |
|
@coreymcollins I even re-ran Gulp just to make sure. It's not full-width: |
|
Yup, looks like this commit is the culprit by adding I'll get with Jo to see if adding that class was intended or if we can remove it without issue. |
coreymcollins
approved these changes
Jan 24, 2019
|
Pushed some updates here to:
|
|
@coreymcollins Awesome! I think we can do it even better. Background Options are technically part of the front-end display, and should probably be consolidated to Display Options. |
|
I like this idea in theory, but one sticky thing is that we don't offer Background Options on the Carousel since each slide has its own options for setting the slide content & background. If we move Background Options into Display Options, we run into a problem where they display in that tab but won't actually be used for the Carousel block. I don't think there's a way to conditionally hide a set of fields in a tab group based on the content block type unless we throw some JS in there. Going to think through it some more and see if there's a way to move them and still elegantly hide them for blocks that won't use Background Options. |
|
I think the best call may be to keep Background Options as-is so we can keep them off of the Carousel block (and any other blocks that may not need/be able to use background options) and merge this puppy in if everything else is looking good from your review. We can always explore sneaky ways to manipulate tabs based on flexible content layouts further, but I'd love to get the grid stuff updated and merged in today if at all possible. Let me know what you think when you have a chance! |
gregrickaby
approved these changes
Feb 5, 2019
|
@coreymcollins Sounds good. Thanks for taking a look! |
coreymcollins
added a commit
that referenced
this pull request
Mar 1, 2019
commit d2f469a Author: jomurgel <jomurgel@users.noreply.github.com> Date: Fri Mar 1 10:51:28 2019 -0700 Hotfix/hotfix 030119 general cleanup (#470) * runs audit and fixes npm * updates terminating comment * adds function to return h1/h2 in hero based on location. * resolves global content block issues with padding/margin * builds * adds doc block * removes duplicate padding declaration * removes additional padding on nested no-background blocks * adds container-width margin removal to global scope * builds * removes container width from global scope * adds no-background.container-width to nesting fixes * adds posts partial for related/recent posts blocks and removes padding * adjusts margin on container with elements * fixes padding issues with carouel * consolodates no-background padding styles commit 0fa0c83 Author: Corey M Collins <coreymcollins@gmail.com> Date: Fri Mar 1 09:38:25 2019 -0600 Feature/#450 remove sidebar (#466) * Removes the sidebar from single posts * Adds the column class to the sidebar-left template to fix the layout * Adjusts responsive styles for sidebar-left to reorder grid and content * Compiles * Removes role from sidebar aside commit 9dce9f0 Author: jomurgel <jomurgel@users.noreply.github.com> Date: Fri Feb 8 13:08:16 2019 -0700 Feature/#438 update grid (#447) * removes neat from style.scss and gulpfile.js * adds media query mixin * removes space * imports media query plugin * combines necessary grid variables and breakpoint variables into one partial * removes rows partial * updates media query usages to match new convention * removes grid helpers * remove instances of `col-` classes * removes container wrappers and appends class and id to body * removes wrapping primary container class * adds container width grid var * removes homepage partial in favor of template-sidebar-right view * changes gutter var to 20 * Cleans up layout structure to utilize flexbox and easy-to-use full/container width elemenets * moves sidebar elements to template partial * updates margin output to utilize mixin * replaces marign with margin mixin * replaces padding with padding mixin * rebuilds header with flexbox and removes span elements from neat * replaces testing.test with wds.test * adds wrapper for flexbox with sidebar * adds container class to articles * adds container class to sidebar * update body class/id and adds grid-container class to header to init flexbox * adds grid wrapper to single post temlate * builds * removes grid-x class (invalidated) * adds filter to move yoast below all elements * adds helper class and removes global acf margins * adds margins to site-main class * wraps sidebar right template * wraps single post (sidebar) * updates header wrap * file cleanup * changes grid-wrapper to display-flex helper * updates button padding to place nice with inputs * cleanup * removes button style restrictions from header button action * adds spacer variable * adds padding to has-background elements * Replaces any instance of rem(24) with $space variable * adds block width field to other options * adds vscode to gitignore * adds container width to container options * adds margin auto and width to site-main * update container width output * updates 'cell' cllass with 'container' class * makes sure container is auto left/right margin * removes unused classes * adds space between accordion elements * updates cta block to follow new conventions * sets to full width and cleans up markup * updates headings for cta * adds helpers for jutify center and align center * moves content width to display options tab * removes undnerlines from buttons * ads font weight * adjusts carouel for new grid * adds empty and missing general content partial * renames _template-sidebar-right to _has-sidebar.scss * removes margin * removes padding * sets postion for background figure * Updates block naming conventions * adds display options for width * updates selector * builds js * brings button styles up to date with links * avoid link conflicts with links with button class * adds helpers for third and half grid elements * adds mixin partial for grid elements * empties partials * updates markup to utilize new grid * builds * resolves phpcs issues * adds filter to run content through — replace force balance tags * adds missing return statement in docblock * styles search from * removes margin from hentry elements * hides pagination of no pages exist * builds * adds missing return doc * adds new sidebar left template * updates documentation and adds helper class * adds classname depending on template in use * removes has-sidebar template and reverts to empty homepage template * adds tempalte sidebar left template to hooks for has-sidebar class * adds helper classes for sidebar elements * adds mixins for sidebar elements * builds * removes margin from last paragraph * adds documentation for grid classes * adds quarter mixin * fixes ul list * fixes blockquote margin * styles blockquote defaults * adds defaults for typography * builds * adds color classes to style backgrounds * wraps heading to allow for full-width elements * adds max-width and margin auto left/right on menu area * styles top of list instead of bottom * adds padding to footer * builds * updates scaffolding styles/elements to follow new conventions * builds * adds default styles for radio/checkbox and select dropdown * updates docs * resolves alignment issues in main navigation * resolves close icon inconsistancies * builds * adds fixes for ie11 * builds * adds container width display options to carousel * removes full-width mixin * adds full-width mixin for helper * updates media query * builds * sets search form container input min-width to 0 * builds * removes omega reset * uses color variables in form elements for radio/checkbox * determins that yoast is active before running metabox_prio filter * replaces normalize with sanitize * removes bourbon as a dependency * removes bourbon from gulp * replaces " with ' in gulpfile * adds directional property mixin * adds margin mixin * adds padding mixin * adds position mixin * adds size mixin * adds unpack shorthand mixin * adds new mixins * removes clearings partial * adds mixin utilities into subfilder * updates clearfix * replaces triangle mixin with markup * removes font smoothing and legibility — set by default * removes wordbreak mixin and inlines requirement — used once * removes z-index mixin — not used * removes vertical alignment mixin * remove margin-auto mixin and inlines — used once * removes hyphens mixin — unsued * removes margin-padding reset and inlines * cleanup mixins and utilities * dds is size, is length and contains falsy function validators * resolves issues with size mixin * removes clearings styles * updates comment odd background color * removes clearfix * removes instances of clearfix or floats * adds flexbox to comments * adds sidebar class to single posts template * cleans up post navigation * adds empty style containers for pagination container * builds * resolve link block issues in social nav * adds container to post navigation * fixes styles issues with header action button/form container * builds * removes unused description * resolves html validation errors * adds missing role="main" to <main> tag * escape apostrophe on 404 page * removes role="main" from <main> tag. * removes clearfix and primary class tweak * adds .hn class to headings loop * removes empty style partials * adds container-width qualifier for has-background padding * escapes apostrophe in content-none partial * rebuilds all * removes empty selectors * removes space * removes empty ruleset * adds example documentation to px to rem and px to em * adds aria label to pgination container * adds default not-animated class to animation class function * run accordion content through _s_get_the_content function * removes empty class and indents correctly * adds container to 404 content * adds $container-offset breakpoint to accomodate breakpoint above container width for padding * reduce container offset * adds missing container classes * updates mobile nav colors * adds container class wrapper * decreases padding on replies which helps mobile * forces default color on buttons during hover/focus * builds * resolves phpcs error * replaces `@extend` with duplicate styles * builds * adds id to carousel slides inside the `_s_display_block_options` function * adds -image to card image alt tag to avoid duplicate link text error * adds title field to video background * adds conditional logic to video background title * adds background video alt tag * updates header nav * removes padding from contaienr with background on mobile devices * builds * Moves the enqueue of Slick scripts to avoid loading CSS in the footer incorrectly * Adjusts some indentations * Adds a fallback for video background if no description is set to avoid an empty space * Adjusts tags for video backgrounds * Fixes an output issue with footer social links * Rearranges accordion buttons to fix some a11y issues * Fixes a spacing issue * Adds a play/pause button so our background videos are more accessible * Compiles * Adjusts button screen reader text * Adds a check to see if an image exists. Sometimes it may not! * restructures main nav wp_nav_menu and adds aria label * adds container class to nav wrapper * cleans up styles * adds container to nav menu ul * resolves padding issues on desktop devices for main navigation * removes unecessary acf-content-blocks class if password protected page is password protected * cleanup * builds * Adds a hidden h1 post title to the ACF page template for screen readers * resolves issues with searchform width on larger screens * fixes calc issue with variable * builds * removes container class from <main> and moves to ternary in acf template * Fixes an extra space in the ACF template * Fixes a space issue in the carousel class * Adjusts carousel markup and class names to pull in color and animation * Moves colors and animations to Display Options instead of Other Options * Removes references to Bourbon and Neat throughout various files * Updates Yarn file
coreymcollins
added a commit
that referenced
this pull request
Mar 1, 2019
commit 6bde318 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Mar 1 15:43:06 2019 -0600 Compiles commit b1c54ba Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Mar 1 15:41:35 2019 -0600 Squashed commit of the following: commit d2f469a Author: jomurgel <jomurgel@users.noreply.github.com> Date: Fri Mar 1 10:51:28 2019 -0700 Hotfix/hotfix 030119 general cleanup (#470) * runs audit and fixes npm * updates terminating comment * adds function to return h1/h2 in hero based on location. * resolves global content block issues with padding/margin * builds * adds doc block * removes duplicate padding declaration * removes additional padding on nested no-background blocks * adds container-width margin removal to global scope * builds * removes container width from global scope * adds no-background.container-width to nesting fixes * adds posts partial for related/recent posts blocks and removes padding * adjusts margin on container with elements * fixes padding issues with carouel * consolodates no-background padding styles commit 0fa0c83 Author: Corey M Collins <coreymcollins@gmail.com> Date: Fri Mar 1 09:38:25 2019 -0600 Feature/#450 remove sidebar (#466) * Removes the sidebar from single posts * Adds the column class to the sidebar-left template to fix the layout * Adjusts responsive styles for sidebar-left to reorder grid and content * Compiles * Removes role from sidebar aside commit 9dce9f0 Author: jomurgel <jomurgel@users.noreply.github.com> Date: Fri Feb 8 13:08:16 2019 -0700 Feature/#438 update grid (#447) * removes neat from style.scss and gulpfile.js * adds media query mixin * removes space * imports media query plugin * combines necessary grid variables and breakpoint variables into one partial * removes rows partial * updates media query usages to match new convention * removes grid helpers * remove instances of `col-` classes * removes container wrappers and appends class and id to body * removes wrapping primary container class * adds container width grid var * removes homepage partial in favor of template-sidebar-right view * changes gutter var to 20 * Cleans up layout structure to utilize flexbox and easy-to-use full/container width elemenets * moves sidebar elements to template partial * updates margin output to utilize mixin * replaces marign with margin mixin * replaces padding with padding mixin * rebuilds header with flexbox and removes span elements from neat * replaces testing.test with wds.test * adds wrapper for flexbox with sidebar * adds container class to articles * adds container class to sidebar * update body class/id and adds grid-container class to header to init flexbox * adds grid wrapper to single post temlate * builds * removes grid-x class (invalidated) * adds filter to move yoast below all elements * adds helper class and removes global acf margins * adds margins to site-main class * wraps sidebar right template * wraps single post (sidebar) * updates header wrap * file cleanup * changes grid-wrapper to display-flex helper * updates button padding to place nice with inputs * cleanup * removes button style restrictions from header button action * adds spacer variable * adds padding to has-background elements * Replaces any instance of rem(24) with $space variable * adds block width field to other options * adds vscode to gitignore * adds container width to container options * adds margin auto and width to site-main * update container width output * updates 'cell' cllass with 'container' class * makes sure container is auto left/right margin * removes unused classes * adds space between accordion elements * updates cta block to follow new conventions * sets to full width and cleans up markup * updates headings for cta * adds helpers for jutify center and align center * moves content width to display options tab * removes undnerlines from buttons * ads font weight * adjusts carouel for new grid * adds empty and missing general content partial * renames _template-sidebar-right to _has-sidebar.scss * removes margin * removes padding * sets postion for background figure * Updates block naming conventions * adds display options for width * updates selector * builds js * brings button styles up to date with links * avoid link conflicts with links with button class * adds helpers for third and half grid elements * adds mixin partial for grid elements * empties partials * updates markup to utilize new grid * builds * resolves phpcs issues * adds filter to run content through — replace force balance tags * adds missing return statement in docblock * styles search from * removes margin from hentry elements * hides pagination of no pages exist * builds * adds missing return doc * adds new sidebar left template * updates documentation and adds helper class * adds classname depending on template in use * removes has-sidebar template and reverts to empty homepage template * adds tempalte sidebar left template to hooks for has-sidebar class * adds helper classes for sidebar elements * adds mixins for sidebar elements * builds * removes margin from last paragraph * adds documentation for grid classes * adds quarter mixin * fixes ul list * fixes blockquote margin * styles blockquote defaults * adds defaults for typography * builds * adds color classes to style backgrounds * wraps heading to allow for full-width elements * adds max-width and margin auto left/right on menu area * styles top of list instead of bottom * adds padding to footer * builds * updates scaffolding styles/elements to follow new conventions * builds * adds default styles for radio/checkbox and select dropdown * updates docs * resolves alignment issues in main navigation * resolves close icon inconsistancies * builds * adds fixes for ie11 * builds * adds container width display options to carousel * removes full-width mixin * adds full-width mixin for helper * updates media query * builds * sets search form container input min-width to 0 * builds * removes omega reset * uses color variables in form elements for radio/checkbox * determins that yoast is active before running metabox_prio filter * replaces normalize with sanitize * removes bourbon as a dependency * removes bourbon from gulp * replaces " with ' in gulpfile * adds directional property mixin * adds margin mixin * adds padding mixin * adds position mixin * adds size mixin * adds unpack shorthand mixin * adds new mixins * removes clearings partial * adds mixin utilities into subfilder * updates clearfix * replaces triangle mixin with markup * removes font smoothing and legibility — set by default * removes wordbreak mixin and inlines requirement — used once * removes z-index mixin — not used * removes vertical alignment mixin * remove margin-auto mixin and inlines — used once * removes hyphens mixin — unsued * removes margin-padding reset and inlines * cleanup mixins and utilities * dds is size, is length and contains falsy function validators * resolves issues with size mixin * removes clearings styles * updates comment odd background color * removes clearfix * removes instances of clearfix or floats * adds flexbox to comments * adds sidebar class to single posts template * cleans up post navigation * adds empty style containers for pagination container * builds * resolve link block issues in social nav * adds container to post navigation * fixes styles issues with header action button/form container * builds * removes unused description * resolves html validation errors * adds missing role="main" to <main> tag * escape apostrophe on 404 page * removes role="main" from <main> tag. * removes clearfix and primary class tweak * adds .hn class to headings loop * removes empty style partials * adds container-width qualifier for has-background padding * escapes apostrophe in content-none partial * rebuilds all * removes empty selectors * removes space * removes empty ruleset * adds example documentation to px to rem and px to em * adds aria label to pgination container * adds default not-animated class to animation class function * run accordion content through _s_get_the_content function * removes empty class and indents correctly * adds container to 404 content * adds $container-offset breakpoint to accomodate breakpoint above container width for padding * reduce container offset * adds missing container classes * updates mobile nav colors * adds container class wrapper * decreases padding on replies which helps mobile * forces default color on buttons during hover/focus * builds * resolves phpcs error * replaces `@extend` with duplicate styles * builds * adds id to carousel slides inside the `_s_display_block_options` function * adds -image to card image alt tag to avoid duplicate link text error * adds title field to video background * adds conditional logic to video background title * adds background video alt tag * updates header nav * removes padding from contaienr with background on mobile devices * builds * Moves the enqueue of Slick scripts to avoid loading CSS in the footer incorrectly * Adjusts some indentations * Adds a fallback for video background if no description is set to avoid an empty space * Adjusts tags for video backgrounds * Fixes an output issue with footer social links * Rearranges accordion buttons to fix some a11y issues * Fixes a spacing issue * Adds a play/pause button so our background videos are more accessible * Compiles * Adjusts button screen reader text * Adds a check to see if an image exists. Sometimes it may not! * restructures main nav wp_nav_menu and adds aria label * adds container class to nav wrapper * cleans up styles * adds container to nav menu ul * resolves padding issues on desktop devices for main navigation * removes unecessary acf-content-blocks class if password protected page is password protected * cleanup * builds * Adds a hidden h1 post title to the ACF page template for screen readers * resolves issues with searchform width on larger screens * fixes calc issue with variable * builds * removes container class from <main> and moves to ternary in acf template * Fixes an extra space in the ACF template * Fixes a space issue in the carousel class * Adjusts carousel markup and class names to pull in color and animation * Moves colors and animations to Display Options instead of Other Options * Removes references to Bourbon and Neat throughout various files * Updates Yarn file commit d2d7a78 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:35:31 2019 -0600 Compiles styles commit 127cc17 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:35:25 2019 -0600 Adds Gutenberg font size classes commit cd0a578 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:22:41 2019 -0600 Gulps the theme commit d6c310c Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:21:40 2019 -0600 Compiles commit 7b998c8 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:21:35 2019 -0600 Adds support for Gutenberg color/background class names commit 2abb31a Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:02:31 2019 -0600 Adds responsive embed support (and it’s pretty neat) commit 48dcf7c Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:00:33 2019 -0600 Adds style editor support commit 95c5a04 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:00:23 2019 -0600 Adds font size support commit 6273c6e Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 13:50:55 2019 -0600 Adds wide support commit a1dbd11 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 13:46:35 2019 -0600 Adds Gutenberg color palette support commit b32e4fa Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 13:46:06 2019 -0600 Copies our ACF color settings into a Gutenberg-ready array
coreymcollins
added a commit
that referenced
this pull request
Mar 1, 2019
commit 064d320 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Mar 1 16:10:15 2019 -0600 Adds CSS for the Goots full-width class commit 6bde318 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Mar 1 15:43:06 2019 -0600 Compiles commit b1c54ba Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Mar 1 15:41:35 2019 -0600 Squashed commit of the following: commit d2f469a Author: jomurgel <jomurgel@users.noreply.github.com> Date: Fri Mar 1 10:51:28 2019 -0700 Hotfix/hotfix 030119 general cleanup (#470) * runs audit and fixes npm * updates terminating comment * adds function to return h1/h2 in hero based on location. * resolves global content block issues with padding/margin * builds * adds doc block * removes duplicate padding declaration * removes additional padding on nested no-background blocks * adds container-width margin removal to global scope * builds * removes container width from global scope * adds no-background.container-width to nesting fixes * adds posts partial for related/recent posts blocks and removes padding * adjusts margin on container with elements * fixes padding issues with carouel * consolodates no-background padding styles commit 0fa0c83 Author: Corey M Collins <coreymcollins@gmail.com> Date: Fri Mar 1 09:38:25 2019 -0600 Feature/#450 remove sidebar (#466) * Removes the sidebar from single posts * Adds the column class to the sidebar-left template to fix the layout * Adjusts responsive styles for sidebar-left to reorder grid and content * Compiles * Removes role from sidebar aside commit 9dce9f0 Author: jomurgel <jomurgel@users.noreply.github.com> Date: Fri Feb 8 13:08:16 2019 -0700 Feature/#438 update grid (#447) * removes neat from style.scss and gulpfile.js * adds media query mixin * removes space * imports media query plugin * combines necessary grid variables and breakpoint variables into one partial * removes rows partial * updates media query usages to match new convention * removes grid helpers * remove instances of `col-` classes * removes container wrappers and appends class and id to body * removes wrapping primary container class * adds container width grid var * removes homepage partial in favor of template-sidebar-right view * changes gutter var to 20 * Cleans up layout structure to utilize flexbox and easy-to-use full/container width elemenets * moves sidebar elements to template partial * updates margin output to utilize mixin * replaces marign with margin mixin * replaces padding with padding mixin * rebuilds header with flexbox and removes span elements from neat * replaces testing.test with wds.test * adds wrapper for flexbox with sidebar * adds container class to articles * adds container class to sidebar * update body class/id and adds grid-container class to header to init flexbox * adds grid wrapper to single post temlate * builds * removes grid-x class (invalidated) * adds filter to move yoast below all elements * adds helper class and removes global acf margins * adds margins to site-main class * wraps sidebar right template * wraps single post (sidebar) * updates header wrap * file cleanup * changes grid-wrapper to display-flex helper * updates button padding to place nice with inputs * cleanup * removes button style restrictions from header button action * adds spacer variable * adds padding to has-background elements * Replaces any instance of rem(24) with $space variable * adds block width field to other options * adds vscode to gitignore * adds container width to container options * adds margin auto and width to site-main * update container width output * updates 'cell' cllass with 'container' class * makes sure container is auto left/right margin * removes unused classes * adds space between accordion elements * updates cta block to follow new conventions * sets to full width and cleans up markup * updates headings for cta * adds helpers for jutify center and align center * moves content width to display options tab * removes undnerlines from buttons * ads font weight * adjusts carouel for new grid * adds empty and missing general content partial * renames _template-sidebar-right to _has-sidebar.scss * removes margin * removes padding * sets postion for background figure * Updates block naming conventions * adds display options for width * updates selector * builds js * brings button styles up to date with links * avoid link conflicts with links with button class * adds helpers for third and half grid elements * adds mixin partial for grid elements * empties partials * updates markup to utilize new grid * builds * resolves phpcs issues * adds filter to run content through — replace force balance tags * adds missing return statement in docblock * styles search from * removes margin from hentry elements * hides pagination of no pages exist * builds * adds missing return doc * adds new sidebar left template * updates documentation and adds helper class * adds classname depending on template in use * removes has-sidebar template and reverts to empty homepage template * adds tempalte sidebar left template to hooks for has-sidebar class * adds helper classes for sidebar elements * adds mixins for sidebar elements * builds * removes margin from last paragraph * adds documentation for grid classes * adds quarter mixin * fixes ul list * fixes blockquote margin * styles blockquote defaults * adds defaults for typography * builds * adds color classes to style backgrounds * wraps heading to allow for full-width elements * adds max-width and margin auto left/right on menu area * styles top of list instead of bottom * adds padding to footer * builds * updates scaffolding styles/elements to follow new conventions * builds * adds default styles for radio/checkbox and select dropdown * updates docs * resolves alignment issues in main navigation * resolves close icon inconsistancies * builds * adds fixes for ie11 * builds * adds container width display options to carousel * removes full-width mixin * adds full-width mixin for helper * updates media query * builds * sets search form container input min-width to 0 * builds * removes omega reset * uses color variables in form elements for radio/checkbox * determins that yoast is active before running metabox_prio filter * replaces normalize with sanitize * removes bourbon as a dependency * removes bourbon from gulp * replaces " with ' in gulpfile * adds directional property mixin * adds margin mixin * adds padding mixin * adds position mixin * adds size mixin * adds unpack shorthand mixin * adds new mixins * removes clearings partial * adds mixin utilities into subfilder * updates clearfix * replaces triangle mixin with markup * removes font smoothing and legibility — set by default * removes wordbreak mixin and inlines requirement — used once * removes z-index mixin — not used * removes vertical alignment mixin * remove margin-auto mixin and inlines — used once * removes hyphens mixin — unsued * removes margin-padding reset and inlines * cleanup mixins and utilities * dds is size, is length and contains falsy function validators * resolves issues with size mixin * removes clearings styles * updates comment odd background color * removes clearfix * removes instances of clearfix or floats * adds flexbox to comments * adds sidebar class to single posts template * cleans up post navigation * adds empty style containers for pagination container * builds * resolve link block issues in social nav * adds container to post navigation * fixes styles issues with header action button/form container * builds * removes unused description * resolves html validation errors * adds missing role="main" to <main> tag * escape apostrophe on 404 page * removes role="main" from <main> tag. * removes clearfix and primary class tweak * adds .hn class to headings loop * removes empty style partials * adds container-width qualifier for has-background padding * escapes apostrophe in content-none partial * rebuilds all * removes empty selectors * removes space * removes empty ruleset * adds example documentation to px to rem and px to em * adds aria label to pgination container * adds default not-animated class to animation class function * run accordion content through _s_get_the_content function * removes empty class and indents correctly * adds container to 404 content * adds $container-offset breakpoint to accomodate breakpoint above container width for padding * reduce container offset * adds missing container classes * updates mobile nav colors * adds container class wrapper * decreases padding on replies which helps mobile * forces default color on buttons during hover/focus * builds * resolves phpcs error * replaces `@extend` with duplicate styles * builds * adds id to carousel slides inside the `_s_display_block_options` function * adds -image to card image alt tag to avoid duplicate link text error * adds title field to video background * adds conditional logic to video background title * adds background video alt tag * updates header nav * removes padding from contaienr with background on mobile devices * builds * Moves the enqueue of Slick scripts to avoid loading CSS in the footer incorrectly * Adjusts some indentations * Adds a fallback for video background if no description is set to avoid an empty space * Adjusts tags for video backgrounds * Fixes an output issue with footer social links * Rearranges accordion buttons to fix some a11y issues * Fixes a spacing issue * Adds a play/pause button so our background videos are more accessible * Compiles * Adjusts button screen reader text * Adds a check to see if an image exists. Sometimes it may not! * restructures main nav wp_nav_menu and adds aria label * adds container class to nav wrapper * cleans up styles * adds container to nav menu ul * resolves padding issues on desktop devices for main navigation * removes unecessary acf-content-blocks class if password protected page is password protected * cleanup * builds * Adds a hidden h1 post title to the ACF page template for screen readers * resolves issues with searchform width on larger screens * fixes calc issue with variable * builds * removes container class from <main> and moves to ternary in acf template * Fixes an extra space in the ACF template * Fixes a space issue in the carousel class * Adjusts carousel markup and class names to pull in color and animation * Moves colors and animations to Display Options instead of Other Options * Removes references to Bourbon and Neat throughout various files * Updates Yarn file commit d2d7a78 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:35:31 2019 -0600 Compiles styles commit 127cc17 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:35:25 2019 -0600 Adds Gutenberg font size classes commit cd0a578 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:22:41 2019 -0600 Gulps the theme commit d6c310c Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:21:40 2019 -0600 Compiles commit 7b998c8 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:21:35 2019 -0600 Adds support for Gutenberg color/background class names commit 2abb31a Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:02:31 2019 -0600 Adds responsive embed support (and it’s pretty neat) commit 48dcf7c Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:00:33 2019 -0600 Adds style editor support commit 95c5a04 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 14:00:23 2019 -0600 Adds font size support commit 6273c6e Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 13:50:55 2019 -0600 Adds wide support commit a1dbd11 Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 13:46:35 2019 -0600 Adds Gutenberg color palette support commit b32e4fa Author: Corey Collins <coreymcollins@gmail.com> Date: Fri Jan 25 13:46:06 2019 -0600 Copies our ACF color settings into a Gutenberg-ready array
coreymcollins
added a commit
that referenced
this pull request
Mar 1, 2019
* Copies our ACF color settings into a Gutenberg-ready array * Adds Gutenberg color palette support * Adds wide support * Adds font size support * Adds style editor support * Adds responsive embed support (and it’s pretty neat) * Adds support for Gutenberg color/background class names * Compiles * Gulps the theme * Adds Gutenberg font size classes * Compiles styles * Squashed commit of the following: commit d2f469a Author: jomurgel <jomurgel@users.noreply.github.com> Date: Fri Mar 1 10:51:28 2019 -0700 Hotfix/hotfix 030119 general cleanup (#470) * runs audit and fixes npm * updates terminating comment * adds function to return h1/h2 in hero based on location. * resolves global content block issues with padding/margin * builds * adds doc block * removes duplicate padding declaration * removes additional padding on nested no-background blocks * adds container-width margin removal to global scope * builds * removes container width from global scope * adds no-background.container-width to nesting fixes * adds posts partial for related/recent posts blocks and removes padding * adjusts margin on container with elements * fixes padding issues with carouel * consolodates no-background padding styles commit 0fa0c83 Author: Corey M Collins <coreymcollins@gmail.com> Date: Fri Mar 1 09:38:25 2019 -0600 Feature/#450 remove sidebar (#466) * Removes the sidebar from single posts * Adds the column class to the sidebar-left template to fix the layout * Adjusts responsive styles for sidebar-left to reorder grid and content * Compiles * Removes role from sidebar aside commit 9dce9f0 Author: jomurgel <jomurgel@users.noreply.github.com> Date: Fri Feb 8 13:08:16 2019 -0700 Feature/#438 update grid (#447) * removes neat from style.scss and gulpfile.js * adds media query mixin * removes space * imports media query plugin * combines necessary grid variables and breakpoint variables into one partial * removes rows partial * updates media query usages to match new convention * removes grid helpers * remove instances of `col-` classes * removes container wrappers and appends class and id to body * removes wrapping primary container class * adds container width grid var * removes homepage partial in favor of template-sidebar-right view * changes gutter var to 20 * Cleans up layout structure to utilize flexbox and easy-to-use full/container width elemenets * moves sidebar elements to template partial * updates margin output to utilize mixin * replaces marign with margin mixin * replaces padding with padding mixin * rebuilds header with flexbox and removes span elements from neat * replaces testing.test with wds.test * adds wrapper for flexbox with sidebar * adds container class to articles * adds container class to sidebar * update body class/id and adds grid-container class to header to init flexbox * adds grid wrapper to single post temlate * builds * removes grid-x class (invalidated) * adds filter to move yoast below all elements * adds helper class and removes global acf margins * adds margins to site-main class * wraps sidebar right template * wraps single post (sidebar) * updates header wrap * file cleanup * changes grid-wrapper to display-flex helper * updates button padding to place nice with inputs * cleanup * removes button style restrictions from header button action * adds spacer variable * adds padding to has-background elements * Replaces any instance of rem(24) with $space variable * adds block width field to other options * adds vscode to gitignore * adds container width to container options * adds margin auto and width to site-main * update container width output * updates 'cell' cllass with 'container' class * makes sure container is auto left/right margin * removes unused classes * adds space between accordion elements * updates cta block to follow new conventions * sets to full width and cleans up markup * updates headings for cta * adds helpers for jutify center and align center * moves content width to display options tab * removes undnerlines from buttons * ads font weight * adjusts carouel for new grid * adds empty and missing general content partial * renames _template-sidebar-right to _has-sidebar.scss * removes margin * removes padding * sets postion for background figure * Updates block naming conventions * adds display options for width * updates selector * builds js * brings button styles up to date with links * avoid link conflicts with links with button class * adds helpers for third and half grid elements * adds mixin partial for grid elements * empties partials * updates markup to utilize new grid * builds * resolves phpcs issues * adds filter to run content through — replace force balance tags * adds missing return statement in docblock * styles search from * removes margin from hentry elements * hides pagination of no pages exist * builds * adds missing return doc * adds new sidebar left template * updates documentation and adds helper class * adds classname depending on template in use * removes has-sidebar template and reverts to empty homepage template * adds tempalte sidebar left template to hooks for has-sidebar class * adds helper classes for sidebar elements * adds mixins for sidebar elements * builds * removes margin from last paragraph * adds documentation for grid classes * adds quarter mixin * fixes ul list * fixes blockquote margin * styles blockquote defaults * adds defaults for typography * builds * adds color classes to style backgrounds * wraps heading to allow for full-width elements * adds max-width and margin auto left/right on menu area * styles top of list instead of bottom * adds padding to footer * builds * updates scaffolding styles/elements to follow new conventions * builds * adds default styles for radio/checkbox and select dropdown * updates docs * resolves alignment issues in main navigation * resolves close icon inconsistancies * builds * adds fixes for ie11 * builds * adds container width display options to carousel * removes full-width mixin * adds full-width mixin for helper * updates media query * builds * sets search form container input min-width to 0 * builds * removes omega reset * uses color variables in form elements for radio/checkbox * determins that yoast is active before running metabox_prio filter * replaces normalize with sanitize * removes bourbon as a dependency * removes bourbon from gulp * replaces " with ' in gulpfile * adds directional property mixin * adds margin mixin * adds padding mixin * adds position mixin * adds size mixin * adds unpack shorthand mixin * adds new mixins * removes clearings partial * adds mixin utilities into subfilder * updates clearfix * replaces triangle mixin with markup * removes font smoothing and legibility — set by default * removes wordbreak mixin and inlines requirement — used once * removes z-index mixin — not used * removes vertical alignment mixin * remove margin-auto mixin and inlines — used once * removes hyphens mixin — unsued * removes margin-padding reset and inlines * cleanup mixins and utilities * dds is size, is length and contains falsy function validators * resolves issues with size mixin * removes clearings styles * updates comment odd background color * removes clearfix * removes instances of clearfix or floats * adds flexbox to comments * adds sidebar class to single posts template * cleans up post navigation * adds empty style containers for pagination container * builds * resolve link block issues in social nav * adds container to post navigation * fixes styles issues with header action button/form container * builds * removes unused description * resolves html validation errors * adds missing role="main" to <main> tag * escape apostrophe on 404 page * removes role="main" from <main> tag. * removes clearfix and primary class tweak * adds .hn class to headings loop * removes empty style partials * adds container-width qualifier for has-background padding * escapes apostrophe in content-none partial * rebuilds all * removes empty selectors * removes space * removes empty ruleset * adds example documentation to px to rem and px to em * adds aria label to pgination container * adds default not-animated class to animation class function * run accordion content through _s_get_the_content function * removes empty class and indents correctly * adds container to 404 content * adds $container-offset breakpoint to accomodate breakpoint above container width for padding * reduce container offset * adds missing container classes * updates mobile nav colors * adds container class wrapper * decreases padding on replies which helps mobile * forces default color on buttons during hover/focus * builds * resolves phpcs error * replaces `@extend` with duplicate styles * builds * adds id to carousel slides inside the `_s_display_block_options` function * adds -image to card image alt tag to avoid duplicate link text error * adds title field to video background * adds conditional logic to video background title * adds background video alt tag * updates header nav * removes padding from contaienr with background on mobile devices * builds * Moves the enqueue of Slick scripts to avoid loading CSS in the footer incorrectly * Adjusts some indentations * Adds a fallback for video background if no description is set to avoid an empty space * Adjusts tags for video backgrounds * Fixes an output issue with footer social links * Rearranges accordion buttons to fix some a11y issues * Fixes a spacing issue * Adds a play/pause button so our background videos are more accessible * Compiles * Adjusts button screen reader text * Adds a check to see if an image exists. Sometimes it may not! * restructures main nav wp_nav_menu and adds aria label * adds container class to nav wrapper * cleans up styles * adds container to nav menu ul * resolves padding issues on desktop devices for main navigation * removes unecessary acf-content-blocks class if password protected page is password protected * cleanup * builds * Adds a hidden h1 post title to the ACF page template for screen readers * resolves issues with searchform width on larger screens * fixes calc issue with variable * builds * removes container class from <main> and moves to ternary in acf template * Fixes an extra space in the ACF template * Fixes a space issue in the carousel class * Adjusts carousel markup and class names to pull in color and animation * Moves colors and animations to Display Options instead of Other Options * Removes references to Bourbon and Neat throughout various files * Updates Yarn file * Compiles * Adds CSS for the Goots full-width class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #438
DESCRIPTION
Much of the documentation for these updates were added to the documentation doc below: https://docs.google.com/document/d/1o1zfqeT5bcdu4VsCHCOKCbO72YMKjb7509I83srkzKU/edit#heading=h.b1ma2w6tlbd
The main push here was removing Neat entirely and rebuilding the grid entirely with flexbox from top to bottom.
These grid helpers and mixins showed in the doc above removes the unnecessary flexibility of Neat 1.9x and provides the ability to create the following grid/layout options.
Updates
Removes
Added
I made several opinionated additions here that we're constantly making updates during projects. Those are listed here: https://docs.google.com/document/d/1o1zfqeT5bcdu4VsCHCOKCbO72YMKjb7509I83srkzKU/edit#heading=h.b1ma2w6tlbd
I still think there are many areas we could improve the mixin usage and markup, but there are other issues for that.
SCREENSHOTS
ACF Blocks
Quarter Grid
Radio/Checkbox/Select Updates
OTHER
DOCUMENTATION
The doc below has updates and documentation for these changes and would, if approved, be added to the Wiki:
https://docs.google.com/document/d/1o1zfqeT5bcdu4VsCHCOKCbO72YMKjb7509I83srkzKU/edit#