Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/#368 scheduled block #369

Merged
merged 2 commits into from
May 23, 2018
Merged

Hotfix/#368 scheduled block #369

merged 2 commits into from
May 23, 2018

Conversation

gregrickaby
Copy link
Contributor

Closes #368

DESCRIPTION

  • Because there Hero block is actually a repeatable field, the "expired" check needs to happen in a sub-loop.
  • Fixed PHP warning by checking for none as a background option first, if none is present, just skip everything.

SCREENSHOTS

Set the date to expire on May 2
screenshot

Block no longer displays
screenshot

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

STEPS TO VERIFY

Check out this PR, and try to schedule a Hero block.

DOCUMENTATION

No

@gregrickaby gregrickaby added the bug label May 4, 2018
@gregrickaby gregrickaby requested a review from coreymcollins May 4, 2018 15:25
@gregrickaby gregrickaby merged commit 5bdd402 into master May 23, 2018
@gregrickaby gregrickaby deleted the hotfix/#368-scheduled-block branch September 18, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreymcollins coreymcollins Awaiting requested review from coreymcollins

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gregrickaby