Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change WDS Coding Standards to a dev dependency, update composer.lock. #362

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Change WDS Coding Standards to a dev dependency, update composer.lock. #362

merged 1 commit into from
Apr 9, 2018

Conversation

jmichaelward
Copy link
Contributor

Closes #361

DESCRIPTION

  • Updates WDS Coding Standards in composer.json to a dev dependency.

SCREENSHOTS

n/a

OTHER

This change has no effect on the theme itself - it will work the same as before.

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

STEPS TO VERIFY

  1. Clone the repository.
  2. Run composer install --no-dev.
  3. Confirm that the vendor/ directory does neither WDS Coding Standards, WordPress Coding Standards, nor PHP Code Sniffer.
  4. Run composer install.
  5. Confirm that the vendor/ directory contains the aforementioned libraries.

DOCUMENTATION

Will this pull request require updating the wd_s wiki?
No

gregrickaby
gregrickaby approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@gregrickaby gregrickaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! 👍

@gregrickaby gregrickaby merged commit d0d92ff into WebDevStudios:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregrickaby gregrickaby gregrickaby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmichaelward @gregrickaby