Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/#353-wds-code-standards #359

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Conversation

gregrickaby
Copy link
Contributor

@gregrickaby gregrickaby commented Mar 23, 2018

Closes #353

DESCRIPTION

  • Instead of using the PHPCS, ESLint, and Sass-Lint config files included with wd_s, this new TravisCI config uses our new WDS Code Standards (that we're using locally at WebDevStudios) via Composer.
  • This will require us to remove the @require from our DocBlocks (Yay! 👏) before TravisCI will pass this and future PRs. (TRAVIS WILL FAIL THIS PR - BUT THAT JUST CONFIRMS THIS NEW CONFIG WORKS!! 😄) See here: https://travis-ci.org/WebDevStudios/wd_s/builds/357604425
  • Also adds PHP v7.2 support
  • Finally, this is a precursor to an upcoming ticket to remove all the linting config files from this repo, and instead ask that others just use Composer to manage the linting, as seen here: https://github.com/WebDevStudios/WDS-Coding-Standards/wiki/Installation

SCREENSHOTS

  • None

DOCUMENTATION

  • Yes, I need to write some on how to lint with wd_s

also includes php 7.2 addition
@gregrickaby gregrickaby requested a review from aubreypwd March 23, 2018 21:43
@gregrickaby gregrickaby changed the title update to use wds code standards Hotfix/#353-wds-code-standards Mar 23, 2018
Copy link
Contributor

@aubreypwd aubreypwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gregrickaby gregrickaby merged commit 9dbd8fb into master Mar 24, 2018
@gregrickaby gregrickaby deleted the hotfix/#353-wds-code-standards branch March 24, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants