Add new em() and rem() mixins along with lh() (unitless line height) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd new line height mixins for use with Bourbon 5
|
@jomurgel Can you merge master back into this PR? Hopefully, that'll fix the Travis error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new a mixin partial and includes updated strip-unit,
em(),rem()for use with Bourbon v5. Provides continued support (since depreciation) for these measurements and updates em and rem to use a base context rather than relying on the default font size.Also adds a new line height mixin (
lh()) for use with a$base-context(default 16, which also gets used with theem()andrem()mixins).