-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize and refactor Navigation #273
Comments
Just a follow up... I refactored this on a recent project and would love to demo it. Maybe bring it into wd_s! |
Branch: https://github.com/WebDevStudios/wd_s/compare/theme/navigation-refactor I've made several changes in this branch.
Opened issue #334 to potentially discuss moving related styles together as I did here. Keeping nav-only buttons in with navigation vs with buttons. Opened issue #333 to potentially discuss reworking navigation to target and add classes to each submenu level individually rather than adding a global |
@jomurgel This looks fantastic and is exactly what I had in mind. 🥇 Go ahead and open a PR! |
As discussed internally, we're going to break navigation components (mobile, desktop, etc...) out into separate partials.
The text was updated successfully, but these errors were encountered: