Skip to content

Commit

Permalink
Merge pull request #45 from WebDevStudios/fix-breakpoint-tabs
Browse files Browse the repository at this point in the history 
Correct tabs
  • Loading branch information
@gregrickaby
gregrickaby committed May 26, 2015
2 parents b1982bc + 66ffa94 commit dcbe017
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions sass/utilities/variables/_breakpoints.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
/// Breakpoints Sass list map for Media Queries @mixin
/// @group wds
$breakpoints: (
large-desktop: 105em, // 1680px
desktop: 85.375em, // 1366px
tablet-landscape: 64em, // 1024px
tablet-portrait: 48em, // 768px
phone-landscape: 40em, // 640px
phone-portrait: 22.5em, // 360px
large-desktop: 105em, // 1680px
desktop: 85.375em, // 1366px
tablet-landscape: 64em, // 1024px
tablet-portrait: 48em, // 768px
phone-landscape: 40em, // 640px
phone-portrait: 22.5em, // 360px
);

2 comments on commit dcbe017

@stacyk
Copy link
Contributor

@stacyk stacyk commented on dcbe017 May 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this list be in the reverse order?

$breakpoints: (
phone-portrait: 22.5em, // 360px
phone: 30em, // 480px
phone-landscape: 40em, // 640px
tablet-portrait: 48em, // 768px
tablet-landscape: 64em, // 1024px
desktop: 85.375em, // 1366px
large-desktop: 105em // 1680px
);

I notice it matters when I start to add my front-end display of the breakpoint. Not sure if anyone else has noticed any conflicts in this ordering or not.

Also, the last comma isn't necessary. Just an extra character :)

@aubreypwd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this list be in the reverse order?

Not sure, no experience with issues there.

Also, the last comma isn't necessary. Just an extra character :)

I'm a fan of trailing comma, easy to re-order.

Please sign in to comment.