Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows implementation of wasm2c runtime #1843

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Add windows implementation of wasm2c runtime #1843

merged 3 commits into from
Mar 10, 2022

Conversation

sbc100
Copy link
Member

@sbc100 sbc100 commented Mar 2, 2022 •
edited
Loading

All tests are now passing with cl.exe under x64. With x86 there are some test failure that I believe relate
the use of the x87 registers to pass floating point numbers. I suggest we look into fixing those as a followup.

Split out from #1833

@sbc100 sbc100 force-pushed the wasm_rt_win branch 10 times, most recently from a8cff25 to 954e37d Compare March 2, 2022 16:16
sbc100 added a commit that referenced this pull request Mar 2, 2022
@sbc100
Fix compiler warnings in wasm2c output
ab65ea0 
Use stricter compiler settings and fix all the resulting warnings.
This is precursor to landing windows compiler support for wasm2c.
See #1843.
@sbc100 sbc100 mentioned this pull request Mar 2, 2022
Merged
sbc100 added a commit that referenced this pull request Mar 2, 2022
@sbc100
Fix compiler warnings in wasm2c output
8870a9a 
Use stricter compiler settings and fix all the resulting warnings.
This is precursor to landing windows compiler support for wasm2c.
See #1843.
sbc100 added a commit that referenced this pull request Mar 2, 2022
@sbc100
Fix compiler warnings in wasm2c output
c3bc893 
Use stricter compiler settings and fix all the resulting warnings.
This is precursor to landing windows compiler support for wasm2c.
See #1843.
@sbc100 sbc100 changed the base branch from main to fix_warnings_wasm2c March 2, 2022 17:51
sbc100 added a commit that referenced this pull request Mar 2, 2022
@sbc100
Fix compiler warnings in wasm2c output
9a1e140 
Use stricter compiler settings and fix all the resulting warnings.
This is precursor to landing windows compiler support for wasm2c.
See #1843.
@sbc100 sbc100 force-pushed the fix_warnings_wasm2c branch from c3bc893 to 9a1e140 Compare March 2, 2022 22:36
sbc100 added a commit that referenced this pull request Mar 2, 2022
@sbc100
Fix compiler warnings in wasm2c output
8a1ba54 
Use stricter compiler settings and fix all the resulting warnings.
This is precursor to landing windows compiler support for wasm2c.
See #1843.
@sbc100 sbc100 force-pushed the fix_warnings_wasm2c branch from 9a1e140 to 8a1ba54 Compare March 2, 2022 22:53
sbc100 added a commit that referenced this pull request Mar 3, 2022
@sbc100
Fix compiler warnings in wasm2c output
0ade258 
Use stricter compiler settings and fix all the resulting warnings.
This is precursor to landing windows compiler support for wasm2c.
See #1843.
@sbc100 sbc100 force-pushed the fix_warnings_wasm2c branch from 8a1ba54 to 0ade258 Compare March 3, 2022 01:14
sbc100 added a commit that referenced this pull request Mar 3, 2022
@sbc100
Fix compiler warnings in wasm2c output
1566bba 
Use stricter compiler settings and fix all the resulting warnings.
This is precursor to landing windows compiler support for wasm2c.
See #1843.
@sbc100 sbc100 force-pushed the fix_warnings_wasm2c branch from 0ade258 to 1566bba Compare March 3, 2022 01:34
sbc100 added a commit that referenced this pull request Mar 3, 2022
@sbc100
Fix compiler warnings in wasm2c output
6616e46 
Use stricter compiler settings and fix all the resulting warnings.
This is precursor to landing windows compiler support for wasm2c.
See #1843.
@sbc100 sbc100 force-pushed the fix_warnings_wasm2c branch from 1566bba to 6616e46 Compare March 3, 2022 01:54
sbc100 added a commit that referenced this pull request Mar 9, 2022
@sbc100
Build and run wasm2c-generated code under sanitizers in CI. NFC
1be1810 
Split out from #1843
@sbc100 sbc100 mentioned this pull request Mar 9, 2022
Merged
@sbc100 sbc100 force-pushed the wasm_rt_win branch 2 times, most recently from 26ce566 to a15ef4b Compare March 9, 2022 04:59
sbc100 added a commit that referenced this pull request Mar 9, 2022
@sbc100
Build and run wasm2c-generated code under sanitizers in CI. NFC (#1856)
eed958b 
Split out from #1843
@sbc100 sbc100 force-pushed the wasm_rt_win branch 3 times, most recently from b4d6317 to e192b81 Compare March 9, 2022 07:09
@sbc100 sbc100 force-pushed the wasm_rt_win branch 2 times, most recently from 3693ed4 to a3dc590 Compare March 9, 2022 20:31
@sbc100
Copy link
Member Author

sbc100 commented Mar 9, 2022

I removed a lot of the extra complexity from this change. It now doesn't add any new .c files to wasm2c.. and just includes the very minimum needed to get windows to pass all the tests.

@sbc100 sbc100 requested review from binji and keithw March 9, 2022 20:32
@sbc100 sbc100 force-pushed the wasm_rt_win branch 3 times, most recently from f9a18d3 to 0b76d8a Compare March 9, 2022 21:57
@sbc100
Copy link
Member Author

sbc100 commented Mar 9, 2022

This is now a much smaller PR and does not include a bunch of the stuff from #1833 such as mmap alignment, or splitting the rt library into several C files. All that can come later once its needed/justified I think.

@sbc100
Copy link
Member Author

sbc100 commented Mar 9, 2022

@binji PTAL

binji
binji approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@binji binji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks much better

@sbc100 sbc100 merged commit 6a89e3f into main Mar 10, 2022
@sbc100 sbc100 deleted the wasm_rt_win branch March 10, 2022 02:29
@keithw keithw mentioned this pull request Apr 1, 2022
Closed
@rathann
Copy link
Contributor

rathann commented Apr 4, 2022

[...] With x86 there are some test failure that I believe relate the use of the x87 registers to pass floating point numbers. I suggest we look into fixing those as a followup.

Maybe compare with #1044 as a number of tests are still failing on Linux/x86, too.

@keithw keithw mentioned this pull request Aug 16, 2022
Closed
@keithw keithw mentioned this pull request Nov 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binji binji Awaiting requested review from binji

@keithw keithw Awaiting requested review from keithw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sbc100 @binji @rathann @keithw @ngzhian