Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely disable signal handler on 32-bit #1488

Merged
merged 4 commits into from
Jul 21, 2020
Merged

Completely disable signal handler on 32-bit #1488

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36ef276
Completely disable signal handler on 32-bit
binji Jul 16, 2020
97b3651
Merge branch 'master' into disable-sighandler
binji Jul 20, 2020
6f0ab47
Restructure signal handler check
binji Jul 20, 2020
9dacdc6
.
binji Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions wasm2c/wasm-rt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ extern "C" {
#if defined(__linux__) || defined(__unix__) || defined(__APPLE__)
#if defined(__WORDSIZE) && __WORDSIZE != 64
#warning "Signal handler is only supported on 64-bit architectures"
#undef WASM_RT_MEMCHECK_SIGNAL_HANDLER
#define WASM_RT_MEMCHECK_SIGNAL_HANDLER 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps better not to enable it in the first place just above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but that's only done if it's not already defined, so it could be defined externally too. Though in that case, I guess we'd want to error out instead of warn.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an error would make more sense yeah. undef seems little odd.

Obviously this just a nit.

#else
#define WASM_RT_MEMCHECK_SIGNAL_HANDLER_POSIX 1
#endif
Expand Down