Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for wast2json #1383

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Add documentation for wast2json #1383

merged 2 commits into from
Apr 8, 2020

Conversation

binji
Copy link
Member

@binji binji commented Apr 6, 2020

This primarily is documentation for the JSON format produced.

binji added 2 commits April 6, 2020 16:20
@binji
Add documentation for wast2json
ebefa46 
This primarily is documentation for the JSON format produced.
@binji
Remove json from code blocks since it's not valid JSON
19b89b7
@binji binji requested a review from sbc100 April 6, 2020 23:24
sbc100
sbc100 approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did read every word but basics and structure LGTM.

@binji binji merged commit 392881d into master Apr 8, 2020
@binji binji deleted the wast2json-doc branch April 8, 2020 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binji @sbc100