Canonicalize NaNs in the interpreter #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though we store f32 and f64 values as their representation, we still use the underlying system's implementations for float operations. These have non-deterministic behavior w.r.t. NaNs. This change canoncalizes all NaNs where it is allowed. This excludes `fxx.abs`, `fxx.neg`, `fxx.copysign` and `fxx.reinterpret*`, which always work on the floating-point representation directly, and the `fxx.convert*` instructions, which cannot be NaN because the input is an integer.
This was referenced Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we store f32 and f64 values as their representation, we
still use the underlying system's implementations for float operations.
These have non-deterministic behavior w.r.t. NaNs.
This change canoncalizes all NaNs where it is allowed. This excludes
fxx.abs,fxx.neg,fxx.copysignandfxx.reinterpret*, whichalways work on the floating-point representation directly, and the
fxx.convert*instructions, which cannot be NaN because the input is aninteger.