-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test failures on s390x #1670
Comments
@ngzhian, could this be the result of a byte order dependency in your recent SIMD work? |
Definitely possible. I don't have easy access to run tests on big endian machines. It does look like we take care of endianess in the interpreter though https://github.com/WebAssembly/wabt/blob/6bc09acabcc7ded2ce934613a7ded98a25217d09/src/interp/interp.h |
This is a new kind of ir/ast node/instruction. It has 3 immediates: memarg align, memarg offset, and lane index. This required new visitor functions in all the places. Drive-by cleanup to share the simd lane parsing logic between shuffle, lane op and this new load lane instructions. This requires rebasing some tests because the error messages are slightly different now.
The use of `.v` is incorrect, we should simply use array subscript operator on the Simd type, which takes care of BE systems. For WebAssembly#1670. (Not using fix as I don't have a BE system to verify.)
The use of `.v` is incorrect, we should simply use array subscript operator on the Simd type, which takes care of BE systems. For #1670. (Not using fix as I don't have a BE system to verify.)
@rathann can you help to run the tests on a BE machine to verify that this is fixed? |
I am not actively working on those right now, I'll close this issue as this is fixed, thanks for helping to verify! |
I'm getting new test failures with 1.0.23 on s390x running Fedora 34. The failing tests are:
Here's the log excerpt:
The text was updated successfully, but these errors were encountered: