Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUFA: Assume nothing about the contents of public tables #7234

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

kripken
Copy link
Member

@kripken kripken commented Jan 22, 2025

Imported and exported tables may get new items from the outside, so
we cannot infer values there.

@kripken kripken requested a review from tlively January 22, 2025 00:48
@kripken
Copy link
Member Author

kripken commented Jan 22, 2025

Fuzzer found an issue with rooting tuples - apparently that never happened til this rooting of call_indirect was added. I pushed a fix here, as it is trivial, and easy to test with this PR, though I could split it out too (not sure how to test in that case, though, aside from the gtest).

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes LGTM.

@kripken
Copy link
Member Author

kripken commented Jan 22, 2025

Fuzzer looks happy now too.

@kripken kripken merged commit eb1f90a into WebAssembly:main Jan 22, 2025
13 checks passed
@kripken kripken deleted the gufa.table branch January 22, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants