-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update apollo2 #31
base: master
Are you sure you want to change the base?
update apollo2 #31
Conversation
use last graphql working with last apollo release Use the react-select versius next (no anymore css to be included the new one is js-in-css)
Thanks for the PR! You should never use the "latest" tag on a package version though, as it may break the whole app if some breaking changes are applied to any of those packages. Could you please replace them with |
yes i can of course, i know that, just i'm lazy.. |
|
||
componentWillReceiveProps(props){ | ||
//see https://github.com/apollographql/react-apollo/issues/1611 the problem inherent with componentWillReceiveProps and react-apollo 2 | ||
console.log("TestWillReceiveProps",props) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This console.log
should be removed, as well as the componentWillReceiveProps
event if it's not used anymore.
If you wish to keep the comment, then put it above componentWillMount()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i kept this just to show you the bug after the second click on edit product TestWillReceiveProps will never be showed in console. you can remove the componentWillReceiveProps
and some bug fix (apollo2)