Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update apollo2 #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

update apollo2 #31

wants to merge 4 commits into from

Conversation

simonjoom
Copy link

and some bug fix (apollo2)

simon added 3 commits June 25, 2018 12:03
use last graphql working with last apollo release
Use the react-select versius next (no anymore css to be included the new one is js-in-css)
@Weakky
Copy link
Owner

Weakky commented Jun 25, 2018

Thanks for the PR! You should never use the "latest" tag on a package version though, as it may break the whole app if some breaking changes are applied to any of those packages. Could you please replace them with ^version-number ?

@simonjoom
Copy link
Author

yes i can of course, i know that, just i'm lazy..
as the bug that i found inherent to the version 2 of apollo (i think)


componentWillReceiveProps(props){
//see https://github.com/apollographql/react-apollo/issues/1611 the problem inherent with componentWillReceiveProps and react-apollo 2
console.log("TestWillReceiveProps",props)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This console.log should be removed, as well as the componentWillReceiveProps event if it's not used anymore.

If you wish to keep the comment, then put it above componentWillMount()

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i kept this just to show you the bug after the second click on edit product TestWillReceiveProps will never be showed in console. you can remove the componentWillReceiveProps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants