Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using user credentials during purge background operation #18

Merged
merged 17 commits into from
Mar 22, 2024

Conversation

Nils-van-Schaik
Copy link
Contributor

@Nils-van-Schaik Nils-van-Schaik commented Mar 19, 2024

This fixes an authentication issue with the purging of expired certificates and secrets.

This change also includes the following:

  • Use the AppId in logs and in the UI instead of the ObjectId
  • Show the AppId in the UI and add a link to the app in Entra
  • Update the application names in the table storage to reflect the current name in Entra
  • Remove the HTTP trigger to trigger the purging of expired certificates and secrets. If a manual trigger is required perform a POST /admin/functions/PurgeExpiredCertificatesAndSecrets_Timer?code={{masterKey}}

sschutten
sschutten previously approved these changes Mar 20, 2024
Co-authored-by: Maarten <17746901+snerte@users.noreply.github.com>
sschutten
sschutten previously approved these changes Mar 22, 2024
@sschutten sschutten merged commit 3e9f1cc into main Mar 22, 2024
1 check passed
@sschutten sschutten deleted the fix/invalid-credentials-during-purge branch March 22, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants