refactor: quick transfers handling and finance components #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- src/sections/finance/components/finance-quick-transfer.tsx: - Add `canContinue` state to disable transfer when exceeding max amount. - Update slider `color` to show a warning for invalid values. - Remove unnecessary `focusOnSelect` in slider settings. - Implement `handleCarouselClick` to enable active item selection. - Adjust blur/input/slider change handlers to update `canContinue` state. - Disable transfer button if `canContinue` is false.
|
geolffreym
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance the finance-related components and hooks in the project. The changes include adding new functionalities, improving existing features, and cleaning up the codebase.
Enhancements to Finance Components:
src/hooks/use-metamask.ts: AddedsetAddressto the returned object to allow changing the address.src/sections/finance/components/finance-deposit-from-metamask.tsx: Updated to includesetAddressin theuseMetaMaskhook and addedonChangeWalletprop toFinanceDepositcomponent.src/sections/finance/components/finance-deposit.tsx: AddedonChangeWalletprop to handle address changes and updated the label from "Amount to withdraw" to "Amount to deposit". [1] [2] [3] [4]Code Cleanup and Refactoring:
src/hooks/use-withdraw.ts: Changed therecipienttype fromstringtoAddressfor better type safety.src/sections/finance/components/finance-withdraw-from-metamask.tsx: ReplaceduseWithdrawMetamaskanduseGetVaultBalancewithuseWithdrawand addedsetAddresstouseMetaMask.src/sections/finance/components/finance-withdraw.tsx: Removed unnecessary address input fields and related state management, and addedonChangeWalletprop for changing the address. [1] [2] [3] [4] [5] [6] [7]Improvements to FinanceQuickTransfer Component:
src/sections/finance/components/finance-quick-transfer.tsx: Added state management forcanContinueto enable or disable the transfer button based on the amount validation, and added a click handler for carousel items. [1] [2] [3] [4] [5] [6] [7] [8] [9]