Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unvendor everything #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Unvendor everything #1

wants to merge 2 commits into from

Conversation

WToma
Copy link
Owner

@WToma WToma commented Jul 20, 2022

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-507597

    This is a workaround to MemoryError: Cannot allocate write+execute memory for ffi.callback() pyca/pyopenssl#873. It looks like that up-to-date versions of requests and urllib3 avoid the issues with pyopenssl described in that issue, so the connector is once again able to function.
    However I wasn't able to get the OCSP code to work. So the only way to use this is with insecure_mode=True.

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency: technically this is adding new dependencies on requests and urllib3, since they're no longer vendored.
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

This causes the OCSP checking not to work, so insecure_mode=True will be required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants