Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add AI variant for Tag, Button & Alert [WUI-100] #2676

Merged
merged 8 commits into from
Feb 13, 2025
Merged

Feat: add AI variant for Tag, Button & Alert [WUI-100] #2676

merged 8 commits into from
Feb 13, 2025

Conversation

Isaacmaamouche
Copy link
Contributor

@Isaacmaamouche Isaacmaamouche commented Feb 7, 2025 •
edited
Loading

AI variant design:

Tags

  • Figma
  • Adds a new variant ai

Button

  • Figma
  • Adds a new "mode" ai that alters Primary, tertiary and Ghost variant (similar to the mode danger)

Alert

  • Figma
  • Adds a new variant ai
  • Overrides the CTA props to pass ai to Buttons

@Isaacmaamouche Isaacmaamouche requested review from a team as code owners February 7, 2025 16:36
@linear Linear
Copy link

linear bot commented Feb 7, 2025

WUI-100 Create AI variant

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

👀 Visit Preview

@Isaacmaamouche
Copy link
Contributor Author

@theo-mesnil I imported types for Variant and Size from their theme when available. Good for you? Shold it be like this for all components ?

theo-mesnil
theo-mesnil reviewed Feb 10, 2025
View reviewed changes
@Isaacmaamouche Isaacmaamouche merged commit 59f968a into main Feb 13, 2025
9 checks passed
@Isaacmaamouche Isaacmaamouche deleted the WUI-100-add-ai-variant branch February 13, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theo-mesnil theo-mesnil theo-mesnil approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isaacmaamouche @theo-mesnil