-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMBF C++ client #106
AMBF C++ client #106
Conversation
Addeding joint velocity
* Update README.md Added line to installation steps to pull submodules for blender plugins and other submodules. * defined getters and setters to get/set ObjectCmd children and joint state publish flags * Corrected formatting differences * Added tf_utils, testing * Temporarily moved tf_utils to dvrk package * Start replacing ambf_controller/dvrk/scripts/utilities.py with tf_utils functions. First step is to replace convert_mat_to_frame line 82 to Frame.make_Frame() since it breaks at that point. * made changes to tf_utils * Delete frames.py Removing old file * Checked out tf utils to new branch * reverting all formatting changes * Added Dockerfile and requirements.txt * Added pip requirements * added ros-catkin packages * Added ros-tf libraries * added libusb dependency * Added entrypoint.sh * Modified apt requirements and entrypoint * modified entrypoint * Added workflow also * Updated dockerfile .gitignore * Modified README * Added action to build on pull request * Corrected DockerFile * Added dockerfiles for training to dockerhub. Co-authored-by: Shreyas Chandra Sekhar <cshreyastech@gmail.com>
@adnanmunawar I am not sure why it is showing changes to some of the files. I pulled them from the ambf-1.0 branch. I also compared the sections that show have changes. It also does not show the changes in my git kraken when I compare the branches |
going to reopen a new PR |
Thanks for cleaning this up. There are some files that can still be reverted/removed as they are not significant to the PR. These include: |
The blender-kuka file was purposely changed it now as the inertia tags for the control package. I would like to keep it as it is in our branch. I can revert the other files |
@nag92. Oh that is great that you updated the file, however, better to create a separate PR for it. |
@adnanmunawar the changes have been pushed |
@adnanmunawar what else needs to be done? |
I removed the package.xml and it broke the build. I am going to fix it and then merge |
Add support for a C++ client. The client matchs the python implementation.
The RBDL+Controller code as been moved to its own repo, however the history remains fro tracking and documentation.