New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor createWISELinkLinkElement and createWISELinkButtonElement functions #2627

Merged

hirokiterashima merged 1 commit into develop from issue-2626-refactor-createWISELink-functions

Sep 18, 2020

Member

geoffreykwan commented Sep 18, 2020

Log in as a teacher
Open a project in the Authoring Tool
Open a step that contains an HTML component (or add an HTML component to a step)
Click the "Insert WISE Link" button within Summernote
Add a "Link" and make sure the link works when you preview the project
Add a "Button" and make sure the button works when you preview the project

Closes #2626


          Refactored createWISELinkLinkElement and createWISELinkButtonElement …

0c0a3fe

…functions. #2626

geoffreykwan added the 1 point label

geoffreykwan requested a review from hirokiterashima

September 18, 2020 15:02

geoffreykwan assigned hirokiterashima

hirokiterashima approved these changes

View reviewed changes

Member

hirokiterashima left a comment

Looks good. I found an issue with the wiselinkcontroller that wasn't introduced in this PR, so I will create a new issue.

hirokiterashima merged commit 6ef7d11 into develop

hirokiterashima deleted the issue-2626-refactor-createWISELink-functions branch

September 18, 2020 15:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 point