Fix "Update Editor's Copy" workflow #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was failing because bikeshed was not installed in the `martinthomson/i-d-template@v1` docker image. Installing bikeshed in it is not trivial (that needs to build native extensions but the docker image does not have gcc), so this patch lets bikeshed run outside the docker environment. This also makes this action publish `subresource-loading.html`.
hayatoito
approved these changes
Mar 3, 2022
|
Looks great! Thanks! |
github-actions bot
added a commit
that referenced
this pull request
Mar 3, 2022
SHA: 87e5b4a Reason: push, by @hayatoito Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Mar 3, 2022
SHA: 87e5b4a Reason: push, by @hayatoito Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to hayatoito/webpackage
that referenced
this pull request
Mar 7, 2022
SHA: 87e5b4a Reason: push, by @hayatoito Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to hayatoito/webpackage
that referenced
this pull request
Mar 7, 2022
SHA: 87e5b4a Reason: push, by @hayatoito Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Apr 1, 2022
SHA: 87e5b4a Reason: push, by @hayatoito Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to hayatoito/webpackage
that referenced
this pull request
Apr 22, 2022
SHA: 87e5b4a Reason: push, by @hayatoito Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #704.
It was failing because bikeshed was not installed in the
martinthomson/i-d-template@v1docker image. Installing bikeshed in it is not trivial (that needs to build native extensions but the docker image does not have gcc), so this patch lets bikeshed run outside the docker environment.This also makes this action publish
subresource-loading.html.