-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec: macro reporting support #762
Conversation
Added allowedReportingOrigins field to IG. Added a new registerAdMacro() API that can be called in reportWin().
Protected audience side. Added a todo to pass macro map to fenced frame reporting function defined in fenced frame spec.
@domfarolino @brusshamilton PTAL. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorially this looks mostly fine, but I'd like someone with more domain context to verify that this is sound from that perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorially this lgtm, but it'd be ideal to get approval from someone with more context on the domain specifics.
@domfarolino I previously looked and it LGTM, other than the TODO integration. |
SHA: 6a827bd Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Spec macro reporting support on the Protected Audience side, which includes:
registerAdMacro
to reporting script runner, and deal with registered macros.💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Sep 11, 2023, 3:15 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.