Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: macro reporting support #762

Merged
merged 10 commits into from
Sep 12, 2023
Merged

Spec: macro reporting support #762

merged 10 commits into from
Sep 12, 2023

Conversation

qingxinwu
Copy link
Collaborator

@qingxinwu qingxinwu commented Aug 21, 2023

Spec macro reporting support on the Protected Audience side, which includes:

  1. Add a new allowedReportingOrigins field to IG's ad, and handles it.
  2. Add a new API registerAdMacro to reporting script runner, and deal with registered macros.
  3. Add a todo to pass the macro map to fenced frame config, once the fenced frame spec adds the variable.

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Sep 11, 2023, 3:15 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

Error running preprocessor, returned code: 1.
Traceback (most recent call last):
  File "/sites/api.csswg.org/python310venv/bin/bikeshed", line 8, in 
    sys.exit(main())
  File "/sites/api.csswg.org/python310venv/lib/python3.10/site-packages/bikeshed/cli.py", line 449, in main
    handleSpec(options, extras)
  File "/sites/api.csswg.org/python310venv/lib/python3.10/site-packages/bikeshed/cli.py", line 506, in handleSpec
    doc.preprocess()
  File "/sites/api.csswg.org/python310venv/lib/python3.10/site-packages/bikeshed/Spec.py", line 162, in preprocess
    self.processDocument()
  File "/sites/api.csswg.org/python310venv/lib/python3.10/site-packages/bikeshed/Spec.py", line 283, in processDocument
    u.inlineRemoteIssues(self)
  File "/sites/api.csswg.org/python310venv/lib/python3.10/site-packages/bikeshed/unsortedJunk.py", line 1280, in inlineRemoteIssues
    responses = json.loads(doc.dataFile.fetch("github-issues.json", str=True))
  File "/usr/local/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/local/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Qingxin Wu added 3 commits August 18, 2023 14:14
Added allowedReportingOrigins field to IG.
Added a new registerAdMacro() API that can be called in reportWin().
Protected audience side. Added a todo to pass macro map to fenced frame
reporting function defined in fenced frame spec.
@qingxinwu qingxinwu added the spec Relates to the spec label Aug 21, 2023
@qingxinwu qingxinwu changed the title Spec 3pat macro reporting Spec: macro reporting support Aug 21, 2023
@qingxinwu qingxinwu requested a review from domfarolino August 23, 2023 19:40
@qingxinwu
Copy link
Collaborator Author

@domfarolino @brusshamilton PTAL. Thanks

Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially this looks mostly fine, but I'd like someone with more domain context to verify that this is sound from that perspective.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
Copy link
Collaborator

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorially this lgtm, but it'd be ideal to get approval from someone with more context on the domain specifics.

@gtanzer
Copy link
Contributor

gtanzer commented Aug 31, 2023

@domfarolino I previously looked and it LGTM, other than the TODO integration.

@JensenPaul JensenPaul merged commit 6a827bd into WICG:main Sep 12, 2023
github-actions bot added a commit that referenced this pull request Sep 12, 2023
SHA: 6a827bd
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@qingxinwu qingxinwu deleted the 3pat branch September 12, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Relates to the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants