Spec: Avoid overload of contributeToHistogramOnEvent() #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Private Aggregation spec now defines this function (for the aggregate error reporting feature[0]). This has caused the method to be temporarily overloaded in the Protected Audience spec while the changes to support this new feature have not yet landed. To avoid this issue, we modify the handling to use the new spec mechanism. Note that this PR does not actually implement the new feature, which will be done in a future PR. This PR should not result in any functional changes. [0]: https://github.com/patcg-individual-drafts/private-aggregation-api/blob/main/error_reporting.md
03fbe94 to
c75f509
Compare
|
@qingxinwu, could you PTAL? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Private Aggregation spec now defines this function (for the aggregate error reporting feature). This has caused the method to be temporarily overloaded in the Protected Audience spec while the changes to support this new feature have not yet landed. This issue was raised in #1405.
To avoid this issue, we modify the handling to use the new spec mechanism. Note that this PR does not actually implement the new feature, which will be done in a future PR. This PR should not result in any functional changes.
Preview | Diff