-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should std:nonexistent
cause parse error or fetch error?
#159
Comments
The fact that rows (2) and (3) in the table above are different does seem somewhat surprising, in that I would have expected that import maps only change behaviour at a resolution level, and not the overall resolution semantics. The core of this discrepancy does exactly seem to be the 1.1.2.2 step in resolve-an-imports-match, which seems to be an early validation unlike we get at any other part of the resolver. I can understand The reason for 1.1.2.2 seems to be this comment:
@hiroshige-g could you clarify the concern here? I was under the impression the module map cached error results just like it caches |
This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9
This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9
This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#691821}
This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#691821}
This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#691821}
…n SecureContexts, a=testonly Automatic update from web-platform-tests Expose kv-storage built-in module only on SecureContexts This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#691821} -- wpt-commits: cb808982deeb57212fb856858c1a7716d0ac2ecb wpt-pr: 17863
…n SecureContexts, a=testonly Automatic update from web-platform-tests Expose kv-storage built-in module only on SecureContexts This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#691821} -- wpt-commits: cb808982deeb57212fb856858c1a7716d0ac2ecb wpt-pr: 17863
Built-in module support was removed in #176 so this is no longer applicable. |
…n SecureContexts, a=testonly Automatic update from web-platform-tests Expose kv-storage built-in module only on SecureContexts This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754 Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org> Reviewed-by: Kouhei Ueno <kouheichromium.org> Cr-Commit-Position: refs/heads/master{#691821} -- wpt-commits: cb808982deeb57212fb856858c1a7716d0ac2ecb wpt-pr: 17863 UltraBlame original commit: c1d0da7bf6a9c3b42d025aaedd5f352b6fd1345a
…n SecureContexts, a=testonly Automatic update from web-platform-tests Expose kv-storage built-in module only on SecureContexts This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754 Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org> Reviewed-by: Kouhei Ueno <kouheichromium.org> Cr-Commit-Position: refs/heads/master{#691821} -- wpt-commits: cb808982deeb57212fb856858c1a7716d0ac2ecb wpt-pr: 17863 UltraBlame original commit: c1d0da7bf6a9c3b42d025aaedd5f352b6fd1345a
…n SecureContexts, a=testonly Automatic update from web-platform-tests Expose kv-storage built-in module only on SecureContexts This CL adds actual restriction in Blink implementation. This CL also modifies tests and expectations to match with the current Blink built-in/import maps infra. A subtest in WPT test `import-statement.html` is failing because the current Blink implementation is based on pre-import-map spec and thus importing unavailable built-in causes fetch error. See 'import 'std:nonexistent';' row of WICG/import-maps#159. Bug: 977470 Change-Id: I107f60ed95e1f91d62f468c29c5d741eef13f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702754 Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org> Reviewed-by: Kouhei Ueno <kouheichromium.org> Cr-Commit-Position: refs/heads/master{#691821} -- wpt-commits: cb808982deeb57212fb856858c1a7716d0ac2ecb wpt-pr: 17863 UltraBlame original commit: c1d0da7bf6a9c3b42d025aaedd5f352b6fd1345a
In some cases
std:nonexistent
causes parse errors and in other cases fetch errors.This is probably fine, as we already have larger behavior differences between
import
statements and<script>
'ssrc
attributes (e.g. import maps are applied or not), but anyway creating an issue to track and explain this explicitly.<script type="module" src="std:nonexistent">
import 'std:nonexistent';
import 'std:nonexistent';
+ import map:"std:nonexistent": "std:nonexistent"
import 'std-internal:some';
from non-internalThe text was updated successfully, but these errors were encountered: