Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate user activation to the opener window #117

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Propagate user activation to the opener window #117

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2e7b96
Propagate user activation to the opener window
steimelchrome Mar 20, 2024
e8cf7da
Also activate the pip window when the opener is activated
steimelchrome May 6, 2024
1c6911b
Fix display-mode reference
beaufortfrancois Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 85 additions & 1 deletion spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Abstract: in an always-on-top window.
</pre>

<pre class="link-defaults">
spec:dom; type:dfn; text:origin
spec:html; type:dfn; for:navigable; text:top-level traversable
spec:html; type:dfn; for:Window; text:navigable
spec:url; type:dfn; for:/; text:url
Expand Down Expand Up @@ -473,11 +474,94 @@ picture-in-picture window after focusing, they can always do so using
## CSS display-mode ## {#css-display-mode}

<p>
The CSS display mode media feature [=display mode/picture-in-picture=] lets web developers
The CSS display mode media feature ''@media/display-mode/picture-in-picture'' lets web developers
write specific CSS rules that are only applied when (part of the) the web app is shown in
picture-in-picture mode.
</p>

## User activation propagation ## {#user-activation-propagation}

<p>
Due to the nature of document picture-in-picture windows, event handlers on
buttons within the window often end up actually running in the opener's context.
This can make it unergonomic for websites to call
<a href="https://html.spec.whatwg.org/multipage/interaction.html#activation-consuming-api">activation consuming APIs</a>,
since sometimes the document
picture-in-picture window has <a>transient activation</a> while the opener does
not.

To make this easier, we will update the
<a href="https://html.spec.whatwg.org/multipage/interaction.html#activation-notification">activation notification</a>
steps to also trigger user activation in the opener when triggering user
activation in a document picture-in-picture window. Additionally, when user
activation is triggered in the opener, we will activate same-origin frames
insides the document picture-in-picture window, similar to how same-origin
descendant frames are activated.
</p>

<p class="issue">
Merge this into
<a href="https://html.spec.whatwg.org/multipage/interaction.html#activation-notification">activation notification</a>
steps once it has enough consensus.
</p>

Add three new steps to
<a href="https://html.spec.whatwg.org/multipage/interaction.html#activation-notification">activation notification</a>
after step 4, "<a>Extend</a>
|windows| with the <a>active window</a> of each of |document|'s
<a>descendant navigables</a>, filtered to include only those <a>navigables</a>
whose <a>active document</a>'s <a>origin</a> is <a>same origin</a> with
|document|'s <a>origin</a>":

5. If |document|'s <a>node navigable</a>'s <a>top-level traversable</a>'s
<a>Is Document Picture-in-Picture</a> boolean is <code>true</code>, then
<a>extend</a> |windows| with |document|'s <a>node navigable</a>'s
<a>top-level traversable</a>'s <a>active browsing context</a>'s
<a>opener browsing context</a>'s <a>active window</a>.

6. Let |document picture-in-picture window| be |document|'s <a>node navigable</a>'s
<a>top-level traversable</a>'s <a>active window</a>'s
<a>documentPictureInPicture API</a>'s <a>last-opened window</a>.

7. If |document picture-in-picture window| is not <code>null</code> then
<a>extend</a> |windows| with the <a>active window</a> of each of
|document picture-in-picture window|'s <a>associated document</a>'s
<a>descendant navigables</a>, filtered to include only those
<a>navigables</a> whose <a>active document</a>'s <a>origin</a> is
<a>same origin</a> with |document picture-in-picture window|'s
<a>associated document</a>'s <a>origin</a>.

<p>
Additionally, we need to make sure that this activation is properly consumed so
it can't be used twice (once in the opener and once in the picture-in-picture
window). We do this by adding steps to <a>consume user activation</a> which
consume user activation from the opener when consuming a picture-in-picture
window's user activation, and consuming an associated picture-in-picture
window's user activation when consuming an opener's user activation.
</p>

<p class="issue">
Merge this into <a>consume user activation</a> steps once it has enough
consensus.
</p>

Add three new steps to <a>consume user activation</a> after step 3, "Let
|navigables| be the <a>inclusive descendant navigables</a> of |top|'s
<a>active document</a>.":

4. If |top|'s <a>Is Document Picture-in-Picture</a> boolean is
<code>true</code>, then <a>extend</a> |navigables| with the
<a>inclusive descendant navigables</a> of |top|'s
<a>active browsing context</a>'s <a>opener browsing context</a>'s
<a>active document</a>.

5. Let |document picture-in-picture window| be |top|'s <a>active window</a>'s
<a>documentPictureInPicture API</a>'s <a>last-opened window</a>.

6. If |document picture-in-picture window| is not <code>null</code> then
<a>extend</a> |navigables| with the <a>inclusive descendant navigables</a>
of |document picture-in-picture window|'s <a>associated document</a>.

# Examples # {#examples}

<em>This section is non-normative</em>
Expand Down
Loading